Skip to content

fix(native): add children prop #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2021
Merged

fix(native): add children prop #1705

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d469014
fix(native): add children prop
CodyJasonBennett Oct 4, 2021
6561608
Merge branch 'master' into fix/native-children
CodyJasonBennett Oct 5, 2021
2c08298
Merge branch 'master' into fix/native-children
joshuaellis Oct 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions targets/native/src/animated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ForwardRefExoticComponent } from 'react'
import { ForwardRefExoticComponent, ReactNode } from 'react'
import { ViewStyle, RecursiveArray } from 'react-native'
import {
AssignableKeys,
Expand All @@ -19,9 +19,10 @@ export type WithAnimated = {
} & AnimatedPrimitives

/** The type of an `animated()` component */
export type AnimatedComponent<
T extends ElementType
> = ForwardRefExoticComponent<AnimatedProps<ComponentPropsWithRef<T>>>
export type AnimatedComponent<T extends ElementType> =
ForwardRefExoticComponent<
AnimatedProps<ComponentPropsWithRef<T>> & { children: ReactNode }
Copy link
Contributor

@LinusU LinusU Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have broken the following code for me:

<animated.View style={{ opacity }} onTouchEnd={handleDismiss} />

It now gives this error:

error TS2741: Property 'children' is missing in type '{ style: { opacity: SpringValue<number>; }; onTouchEnd: () => void; }' but required in type '{ children: ReactNode; }'.

I think that this should have been:

Suggested change
AnimatedProps<ComponentPropsWithRef<T>> & { children: ReactNode }
AnimatedProps<ComponentPropsWithRef<T>> & { children?: ReactNode }

Copy link
Member Author

@CodyJasonBennett CodyJasonBennett Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, could you open a PR?

Copy link
Contributor

@LinusU LinusU Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I should probably have linked that one, sorry 😅

#1925

It's merged now 🚀

>

/** The props of an `animated()` component */
export type AnimatedProps<Props extends object> = {
Expand Down