feat(types): better middleware support #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 69a078b:
|
|
Size Change: 0 B Total Size: 9.88 kB ℹ️ View Unchanged
|
src/index.ts
Outdated
Comment on lines
28
to
31
| setState: CustomStoreApi['setState'] | ||
| getState: CustomStoreApi['getState'] | ||
| subscribe: CustomStoreApi['subscribe'] | ||
| destroy: CustomStoreApi['destroy'] |
There was a problem hiding this comment.
If I'm not wrong, these four fields are already in CustomStoreApi, right?
Why not just remove these four lines?
There was a problem hiding this comment.
Nice catch. At a certain commit, it was interface which can't be merged with CustomStoreApi. Now, it's type alias, and we can remove them.
This was referenced Oct 25, 2021
dai-shi
added a commit
that referenced
this pull request
Oct 29, 2021
hiendv
pushed a commit
to hiendv/zustand
that referenced
this pull request
Feb 27, 2023
* feat(types): better middleware support * some more trial * some more trial * Revert "some more trial" This reverts commit c54bf7c. * some more trial * some more trial * some more trial * some more trial * Revert "some more trial" This reverts commit 3aef9e2. * some more trial * Revert "some more trial" This reverts commit fce0cb4. * some more trial * some more trial * some more trial * some more trial * add redux middleware type test * fix with type alias * add devtools and redux combination test * combine to support named set * remove duplicated types
hiendv
pushed a commit
to hiendv/zustand
that referenced
this pull request
Feb 27, 2023
…mndrs#617) * chore(tests): add a use case combining many middleware * simplify middleware types and allow explicit typing reverting some of pmndrs#601 * fix context tests * prettier * refine middleware type test for more coverage and readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, to be honest, I don't like the tricky typescript typing. middleware is very type unfriendly.
I wouldn't build the API with middleware in this typescript era. (see jotai and valtio.)
That said, we still want to have better TS support in zustand.
Even though this makes the code less maintainable, it's worth it.
(We should add more type tests and middleware behavior tests. Any volunteers?)