Permalink
Commits on Aug 16, 2018
  1. test/mpi: Add missing link to mtest utils

    raffenet committed Aug 16, 2018
    This C test in the F08 directory now relies on the MTest utilities,
    but did not have an explicit link to the object file containing
    them. Fixes a compile issue in the Jenkins tests.
    
    Signed-off-by: Wesley Bland <wesley.bland@intel.com>
  2. coll: Fix for useless values coverity error

    tarudoodi authored and raffenet committed Jul 19, 2018
    The MPII_Treealgo_init() and MPII_Recexchalgo_init() just return mpi_errno
    which is set to MPI_SUCCESS. Coverity reported them as useless calls. The commit
    catches and checks return values for all init, cleanup and finalize functions.
    
    Fixes coverity CID 185541
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  3. configure: add shared object option for IBM compiler

    yfguo authored and raffenet committed Aug 14, 2018
    Building shared library with IBM compiler requires `-qmkshrobj` option.
    
    Fix pmodels/mpich#3050
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
Commits on Aug 15, 2018
  1. coll: Remove unused variable assignment

    hajimefu authored and raffenet committed Aug 3, 2018
    `type_size` is set but never used later.
    
    Signed-off-by: Akhil Langer <akhil.langer@intel.com>
  2. coll: Constify params in Iallgatherv_intra_ring

    hajimefu authored and raffenet committed Aug 3, 2018
    `recvcount` and `displs` are defined as `const int *` in other functions
    for Iallgatherv. This patch updates the Iallgatherv_intra_ring
    implementations to make them consistently use const parameters to
    remove compiler warnings.
    
    Signed-off-by: Akhil Langer <akhil.langer@intel.com>
  3. coll: Remove unused variables

    hajimefu authored and raffenet committed Aug 3, 2018
    Signed-off-by: Akhil Langer <akhil.langer@intel.com>
  4. datatype: Initialize handle in MPI_Type_create_resized

    hajimefu authored and raffenet committed Aug 3, 2018
    To suppress a warning.
    
    Signed-off-by: Akhil Langer <akhil.langer@intel.com>
  5. mtest: Fix overzealous search/replace

    raffenet committed Aug 15, 2018
    This file is not a standalone test and therefore should have been
    omitted from the cleanup in [d740c33]. Fixes compiliation errors
    in Jenkins testing with the Fortran 2008 binding enabled.
    
    Signed-off-by: Wesley Bland <wesley.bland@intel.com>
Commits on Aug 14, 2018
  1. mpl: Improve checking for socket functions

    raffenet committed Aug 14, 2018
    Use new macro to check for extra socket libraries before checking the
    availability of inet_ntop and getifaddrs. Fixes an issue on Solaris
    where locality checks were failing in Hydra.
    
    Signed-off-by: Rob Latham <robl@mcs.anl.gov>
  2. confdb: Add check for extra socket libraries

    raffenet committed Aug 14, 2018
    Some platforms (e.g. Solaris) require extra libraries when linking
    sockets programs. Add a check from autoconf-archive that properly
    checks if these are necessary.
    
    Signed-off-by: Rob Latham <robl@mcs.anl.gov>
  3. romio/adio/ime: remove useless inclusion of deprecated header file

    sydidelot authored and raffenet committed Jul 26, 2018
    The header file 'im_client_native2.h' will be deprecated soon
    in favor of file 'ime_native.h'. Also, this include is actually
    not needed and can be safely removed.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  4. romio/adio/ime: remove useless variable declaration

    sydidelot authored and raffenet committed Jul 26, 2018
    The patch removes an uneeded global variable which was declared
    by mistake.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
Commits on Aug 13, 2018
  1. mtest: Add testing for bcast ring algorithm

    akhillanger authored and raffenet committed Jul 31, 2018
    This was missing somehow.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  2. mtest: Set CVAR for algo selection

    akhillanger authored and raffenet committed Jul 31, 2018
    Setting of the CVAR was not being done in the else condition, without
    which the expected algo will not be invoked.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
Commits on Aug 9, 2018
  1. mpi/err: Move shar_mem errcodes from Nemesis to general

    jain-surabhi-23 authored and minsii committed Aug 2, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
    Signed-off-by: Min Si <msi@anl.gov>
  2. ch4: Set mpi_errno correctly after mpl shm call

    jain-surabhi-23 authored and minsii committed Aug 1, 2018
    MPL SHM routine does not return `mpi_errno`. `mpi_errno` should be set
    appropriately after MPL calls.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
    Signed-off-by: Min Si <msi@anl.gov>
  3. mpl/shm: Remove unnecessary variables, dead code

    jain-surabhi-23 authored and minsii committed Aug 1, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
    Signed-off-by: Min Si <msi@anl.gov>
  4. mpl/shm: Check return values of mmap etc

    jain-surabhi-23 authored and minsii committed Aug 1, 2018
    Check return value of internal routines of MPL_SHM* and return -1
    if any failure occurs.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
    Signed-off-by: Min Si <msi@anl.gov>
Commits on Aug 6, 2018
  1. mpir: Add assertion in MPIR_Valid_ptr_class

    hajimefu authored and raffenet committed Jul 27, 2018
    Commit b5d7bb6 did not fix CID 171658 and others.
    This commit adds a similar assertion as b5d7bb6 did but in a upper
    part in the call stack, in order to tell Coverity that the return
    value shouldn't be MPI_SUCCESS if `ptr` is NULL.
    
    Trying to fix CID 171658, 171660, 171723, and maybe more.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
Commits on Aug 3, 2018
  1. comm: Catch returned error

    akhillanger authored and raffenet committed Aug 3, 2018
    Fixes coverity error
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  2. coll: Remove structurally dead code

    akhillanger authored and raffenet committed Aug 3, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  3. coll: Initialize pointers

    akhillanger authored and raffenet committed Aug 3, 2018
    Fixes coverity errors
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  4. coll: Add return value to return statement

    akhillanger authored and raffenet committed Aug 3, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  5. ch4/ofi: Delete unused function

    raffenet committed Apr 12, 2018
    No reviewer.
Commits on Aug 2, 2018
  1. ch4/rma: warning fix for incompatible pointer type

    minsii committed Aug 2, 2018
    Signed-off-by: Hajime Fujita <hajime.fujita@intel.com>
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  2. mpl: use void* type addr in MPL_shm routines.

    minsii committed Aug 2, 2018
    The original code used char* for the address parameter in all MPL_shm*
    routines. We should use void* for the generic memory allocation calls
    and let the caller do type-casting. This patch makes this change, and
    also removes unnecessary char** type-casting or replaces with void**
    casting in both ch3 and ch4 where MPL_shm* is called.
    
    Signed-off-by: Hajime Fujita <hajime.fujita@intel.com>
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  3. coll: Fix more enum usage

    raffenet committed Aug 2, 2018
    A few more that were missed.
    
    No reviewer.
  4. coll: Fix more enum usage

    raffenet committed Aug 2, 2018
    A few places were missed in [f0b5f87]
    
    No reviewer.
  5. hydra2: New process manager

    pavanbalaji authored and raffenet committed Jul 31, 2018
    This commit includes a mostly ground-up rewrite of Hydra. The new code
    uses better abstractions, more scalable data structures, and more
    efficient internal communication. Support for hierarchical launches is
    added for improved startup times on large numbers of nodes. This code
    should be considered experimental. It may change drastically, and will
    likely be renamed.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  6. hydra: Use MPL_host_is_local

    pavanbalaji authored and raffenet committed Aug 1, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  7. mpl: Improved localhost detection

    pavanbalaji authored and raffenet committed Aug 1, 2018
    Added a new localhost detection function in MPL.  This borrows code
    from an existing similar function in Hydra, but optimizes it to
    minimize the number of hostname lookups.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  8. mpl: Add argv serialization/deserialization

    pavanbalaji authored and raffenet committed Feb 22, 2017
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  9. coll: Add missing FUNCNAME

    hajimefu authored and raffenet committed Aug 1, 2018
    Missing FUNCNAME for MPIR_TSP_Iallgather_sched_intra_brucks,
    while having MPIR_FUNC_VERBOSE_STATE_DECL, resulted in a warning
    from autogen.sh.
    
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  10. coll: Fix code formatting

    akhillanger authored and raffenet committed Aug 1, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
  11. coll: Remove unreachable code

    akhillanger authored and raffenet committed Aug 1, 2018
    Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>