maint: Sort input file list #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. Just run the tests for a sanity check. |
hzhou
approved these changes
Mar 28, 2019
so that mpich builds in a reproducible way in spite of indeterministic filesystem readdir order See https://reproducible-builds.org/ for why this is good. Without this patch, README.envvar, /usr/lib64/mpi/gcc/mpich/bin/mpivars and other output files varied between builds. Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> Signed-off-by: Hui Zhou <hzhou321@anl.gov>
|
Reproducible builds is generally a good idea. Make a note here that an even better idea is not just to sort the input dir, but sort the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sort input file list
so that mpich builds in a reproducible way
in spite of indeterministic filesystem readdir order
See https://reproducible-builds.org/ for why this is good.
Without this patch,
README.envvar,/usr/lib64/mpi/gcc/mpich/bin/mpivarsand otheroutput files varied between builds.
This PR was done while working on reproducible builds for openSUSE.