Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Sort input file list #3690

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
3 participants
@bmwiedemann
Copy link
Contributor

commented Mar 25, 2019

Sort input file list
so that mpich builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Without this patch,
README.envvar, /usr/lib64/mpi/gcc/mpich/bin/mpivars and other
output files varied between builds.

This PR was done while working on reproducible builds for openSUSE.

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:sort branch from 2d6233b to 939dff0 Mar 25, 2019

@raffenet

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Seems reasonable to me. Just run the tests for a sanity check.
test:jenkins/ch3/tcp

@hzhou

hzhou approved these changes Mar 28, 2019

Sort input file list
so that mpich builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

Without this patch,
README.envvar, /usr/lib64/mpi/gcc/mpich/bin/mpivars and other
output files varied between builds.

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Signed-off-by: Hui Zhou <hzhou321@anl.gov>

@hzhou hzhou force-pushed the bmwiedemann:sort branch from 939dff0 to 291661b Mar 28, 2019

@hzhou hzhou merged commit 0ea861b into pmodels:master Mar 28, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
whitespace-checker Build finished. No test results found.
Details
@hzhou

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Reproducible builds is generally a good idea. Make a note here that an even better idea is not just to sort the input dir, but sort the CVARS and errmsgs so the output is easier to review and compare. Of course, also these scripts are so old that they generally worth a rewrite and at least use strict and use warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.