Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPL_sockaddr fixes (3.3.x) #4320

Merged
merged 2 commits into from Feb 14, 2020
Merged

MPL_sockaddr fixes (3.3.x) #4320

merged 2 commits into from Feb 14, 2020

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Feb 12, 2020

Pull Request Description

Cherry-picked fixes for MPL_sockaddr usage in 3.3.x. See #4318.

Expected Impact

Fix user-visible bugs.

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • Add Devel Docs in the doc/ directory for any new code design

@raffenet
Copy link
Contributor Author

test:jenkins/ch3/most

1 similar comment
@raffenet
Copy link
Contributor Author

test:jenkins/ch3/most

@hzhou
Copy link
Contributor

hzhou commented Feb 12, 2020

@raffenet You may also want to pick this patch: #4281.

@raffenet
Copy link
Contributor Author

test:jenkins/ch3/most

@raffenet raffenet changed the title ch3: fix improper error handling from MPL_get_sockaddr (3.3.x) ch3: MPL_sockaddr fixes (3.3.x) Feb 12, 2020
@raffenet raffenet changed the title ch3: MPL_sockaddr fixes (3.3.x) MPL_sockaddr fixes (3.3.x) Feb 12, 2020
MPL layer does not directly return mpi_errno. Use MPIR_ERR_CHKANDJUMP
macro to create the appropriate return code. See pmodels#4318.

Cherry-picked from [8d92393].
@raffenet raffenet merged commit fc7154c into pmodels:3.3.x Feb 14, 2020
@raffenet raffenet deleted the sockaddr-fix branch February 14, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants