Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coll: fix allgatherv early return case #6374

Merged
merged 1 commit into from Jan 23, 2023
Merged

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented Jan 21, 2023

Pull Request Description

The localcopy omitted considering displs.

Thanks @mathstuf for discovering the bug. ref: #5034 (comment)

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

The localcopy omitted considering displs.
@hzhou
Copy link
Contributor Author

hzhou commented Jan 21, 2023

@mathstuf Could you verify the fix?

@mathstuf
Copy link

Thanks, will test. Here's a test case I adapted (but haven't run because I built MPICH out-of-source and test/mpi doesn't seem to be set up for that…): mathstuf@1935ffe

@mathstuf
Copy link

That works!

@mathstuf
Copy link

Backport for Fedora requested: https://bugzilla.redhat.com/show_bug.cgi?id=2162892

@hzhou hzhou merged commit d3039c8 into pmodels:main Jan 23, 2023
4 checks passed
@hzhou hzhou deleted the 2301_allgatherv branch January 23, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants