Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfresco 6 Support #78

Open
deas opened this issue Jun 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@deas
Copy link

commented Jun 26, 2018

Hi Peter,

I needed this thing working on Alfresco 6 and it looks like I succeeded. As you point out, version in module.properties requires a bump. Other than that, jackson shipping with Alfresco 6 has a slightly different package structure. Had to drop the sdk parent to get proper deps in.

You might remember that I am not a big fan of amp. Hence, I shifted things around a bit to make them more jar friendly.

This is actually the first time I am using this tool and from what I can tell, it still behaves as advertised.

You might want to check my fork.

Just let me know in case you'd like me to provide you with a PR.

regards
Andreas

@pmonks

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2018

A PR would be great!

Just out of interest. are the changes backwards compatible with Alfresco 5.x?

@pmonks pmonks added the enhancement label Jun 26, 2018

@deas

This comment has been minimized.

Copy link
Author

commented Jun 26, 2018

Package structure of jackson has changed a bit, but I think we can still target all versions of Alfresco with one artifact. It is really about two class imports and constructor initialization we need to replace - namely ObjectMapper and TypeReference. The easiest approach I could come up with is reflection. I'd be fine it and give it a try.

Feel free to test drive my fork before the PR comes in. It's just clone and mvn install.

Offtopic here, but I have just run into another issue. I need cm:content property type support. It is not there yet, is it?

Any opinion about a potential implementation of that?

@pmonks

This comment has been minimized.

Copy link
Owner

commented Aug 23, 2018

Took a look at this this evening, and will continue chipping away at it as I have time.

<mini-rant>
It's quite disappointing to see that AMP support has basically been dropped by Alfresco, necessitating the use of ghastly hacks such as the Maven shade plugin. That's going to cause no end of pain for users and customers who deploy more than a small number of extensions into the same JVM...
</mini-rant>

Regarding d:content properties, that's tracked as issue #5. I've added more commentary there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.