Paul Morie
pmorie

Organizations

@openshift @GoogleCloudPlatform @fedora-cloud @projectatomic @kubernetes
Aug 27, 2016
pmorie commented on pull request kubernetes/kubernetes#31504
@pmorie

I think it's a little late for this in 1.4, flag or not. This is a feature.

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31504
@pmorie

Shared doesn't work right on some kernels, please hold off on this

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31169
@pmorie

@vishh - how do you feel about this going into 1.4?

Aug 26, 2016
@pmorie
Confusing error message when using oc cluster up --use-existing-config with a different IP
Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31146
@pmorie

@pwittrock It fixes a bug -- you can rm -rf / on a box by creating a hostpath PV w/ reclaimpolicy 'recycle'

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31366
@pmorie

I'm not sure that I get why this is necessary, @rootfs. Elaborate?

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin so -- where does this leave us in terms of fixing this bug? I would like to do no harm, firstly, so perhaps we should scrub this WIP code …

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin fair

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin Per-volume might be appropriate if we assume we have a per-volume goroutine that does all the work for a given pod-volume. I don't disl…

Aug 26, 2016
pmorie commented on issue kubernetes/kubernetes#30897
@pmorie

@childsb In the case of a PV, there are two possibilities: Volume controller needs to use secret to do attach/detach Kubelet needs to use secret…

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

You could also use the calling frame info as part of the key instead of manually specifying the intent at the call site.

Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin can't we address this by adding an 'intent' to the key in the map?

Aug 26, 2016
pmorie commented on issue kubernetes/kubernetes#30897
@pmorie

@childsb I don't think that would be the case -- the provisioner is going to run under a system service account / with its own token

Aug 26, 2016
pmorie commented on issue kubernetes/kubernetes#30897
@pmorie

@childsb It seems like it solves the secret on PV issue just as well to me -- use an 'admin' namespace to hold the secrets. What am I missing?

Aug 26, 2016
pmorie commented on issue kubernetes/kubernetes#30897
@pmorie

I think putting the namespace / name of the secret to use in the provisioner parameters is a fine way to start. Do not want to rush into a global s…

Aug 26, 2016
pmorie opened pull request kubernetes/kubernetes#31531
@pmorie
Add log message in Kubelet when controller attach/detach is enabled
1 commit with 3 additions and 0 deletions
Aug 26, 2016
@pmorie
  • @pmorie 3b23b9b
    Add log message in Kubelet when controller attach/detach is enabled
Aug 26, 2016
Aug 26, 2016
pmorie commented on pull request kubernetes/kubernetes#31169
@pmorie

LGTM, will leave final sign-off to @vishh

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31358
@pmorie

@pwittrock Personally, I consider this to be a bugfix. It's a fairly important piece of info which is missing from the kubectl output for this type…

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@kubernetes/sig-storage @thockin @ncdc @derekwaynecarr @eparis @jingxu97 @saad-ali Multiple places need to make calls that examine the file system…

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31169
@pmorie

👀

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin I'm composing a treatise on this subject now. Going to write english before writing more code.

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

@thockin i think there will a couple different ones: <pod-uid>-<volume-type> <pod-uid>-<volume-type>-<volume-name>

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31445
@pmorie

:=1:

Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

Alright, good point about goroutine leaks. I'm going to have to rework this to use goroutinemap.

Aug 25, 2016
pmorie opened pull request kubernetes/kubernetes#31445
@pmorie
Improve godoc for goroutinemap
1 commit with 9 additions and 3 deletions
Aug 25, 2016
Aug 25, 2016
pmorie commented on pull request kubernetes/kubernetes#31379
@pmorie

oops, that was supposed to be 5 * time.Second

Aug 25, 2016
pmorie commented on pull request openshift/origin#10571
@pmorie

lgtm, [merge]