Matcap #23
Matcap #23
Conversation
src/pmp/visualization/MatCapShader.h
Outdated
| @@ -0,0 +1,63 @@ | |||
| //============================================================================= | |||
| // Copyright (C) 2011-2018 The pmp-library developers | |||
There was a problem hiding this comment.
Copyright should be bumped to 2020
There was a problem hiding this comment.
for new files or for changed files?
There was a problem hiding this comment.
Should be updated to current year on every change.
There was a problem hiding this comment.
updated for all files that changed
| " vec3 N = normalize(v2f_normal);\n" | ||
| " vec3 V = normalize(v2f_view);\n" | ||
| " \n" | ||
| //" if (!gl_FrontFacing) N = -N;\n" // gl_FrontFacing does not work on Mario's new MacBook |
There was a problem hiding this comment.
this code will be removed anyway. the new one does not have dead lines.
| @@ -40,7 +41,7 @@ SurfaceMeshGL::SurfaceMeshGL() | |||
|
|
|||
| // material parameters | |||
| front_color_ = vec3(0.6, 0.6, 0.6); | |||
| back_color_ = vec3(0.5, 0.0, 0.0); | |||
There was a problem hiding this comment.
Why this change? The red rendering of back faces is quite useful, e.g., for detecting intersections or fold-overs.
There was a problem hiding this comment.
don't know anymore. something didn't work. let's change it back.
There was a problem hiding this comment.
Okay, I just pushed a change for that.
The PR adds mat-cap textures to
src/pmp/visualization/SurfaceMeshGL. Since they are a special kind of spherical environment map, the are used in the rendering mode "Texture".The external repository pmp-data has been updated to include some of Blender's mat-cap files. Find them in
external/pmp-data/matcap/.Currently
mviewis the only application using mat-caps, by specifying-m matcap-texture.jpgas command line parameter. We maybe should add a common command line parsing to all applications that derive from MeshViewer...The PR also improves the parameter passing and file loding in case of an emscripten WebAssembly build. The
mviewweb-application now supports to add these parameters in the URL's query part:model=my_model.offtexture=my_texture.jpgmaterial=my-matcap.jpgWhen the web-app is embedded using an iframe, these attributes can also be added the element attributes to the iframe.