use spawn instead of exec to run commands #6

Closed
pmuellr opened this Issue Jan 10, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Owner

pmuellr commented Jan 10, 2012

Currently, wr uses child_process.exec() to run commands. Unfortunately, this buffers the output - not friendly. child_process.spawn(), on the other hand, does not buffer the output.

The default should probably be to use spawn(). This will require parsing the cmd, presumably by whitespace tokens, destroying any potential quoting you might have done in your command. But commands should be "simple" anyway, right? :-)

So, default to parse command and use spawn, with a command-line option to use exec() instead.

@pmuellr pmuellr closed this in 8a28ecf Jan 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment