Pete Muir pmuir

Organizations

@jboss @jbossas @seam @arquillian @weld @infinispan @forge @datagrids @aerogear @jboss-eap @agorava @awestruct @jboss-developer @jboss-jdf @cdi-spec @windup
pmuir commented on pull request windup/windup#629
@pmuir

What about using default values that can be overridden using bash env vars. This is done using FOO=${FOO:default_value}

pmuir commented on pull request windup/windup#629
@pmuir

Use default values in the script that can be overridden with env vars? in bash use ={VAR_NAME:default_value}

pmuir pushed to master at pmuir/blinkr
@pmuir
pmuir merged pull request pmuir/blinkr#12
@pmuir
Angular merge
29 commits with 598 additions and 347 deletions
pmuir commented on pull request pmuir/blinkr#12
@pmuir

It looks good, but calling that var non_internal_links is a bit confusing, perhaps?

@pmuir
pmuir commented on pull request pmuir/blinkr#12
@pmuir

An answer here could be to do a combo. First check the sitemap. If it's not there, check the URL using typhoeus. WDYT?

pmuir commented on pull request pmuir/blinkr#12
@pmuir

I think there is definitely a situation where there will be pages on the same domain that aren't in the sitemap. This happened e.g. on jboss.org

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Could be worth looking at as a later optimisation.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Report looks good.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

I'm not sure this is the right way to do this. It's an interesting idea for a new plugin, but the links plugin should check that links work.

@pmuir

Well, I guess you have some server (which is dockerlab)? So then run a DNS server there in a docker container.

@pmuir

Provide a real DNS server with a real DNS entry. Unfortunately I don't have a solution right now. I tried to add a DNS server to our instructor lab…

@pmuir

Docker is a bit odd about it's DNS usage. I've found it more reliable to have real DNS in use, not /etc/hosts

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Right, you need to use phantomjs to load the pages on the site, then typhoeus to load any links from that page, to check they don’t result in error…

pmuir commented on pull request pmuir/blinkr#12
@pmuir

What other sort of caching would make sense for phantomjs? I'm not a fan of keeping stuff around for longer than the run - it seems unsafe to me.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Yeah, I never tried what you are doing, so it may well be a good place. I just wanted to check that you had tested this against GET only.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Currently PhantomJS fetches and renders the page, it then saves off any errors (resource and javascript) it finds while it renders the page (this …

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Currently the link extension is the only one that makes additional calls. Before there wasn't actually a typhoeus variable so it went in nil into …

pmuir commented on pull request pmuir/blinkr#12
@pmuir

I've not seen that either to be honest. Maybe ask them?

pmuir commented on pull request pmuir/blinkr#12
@pmuir

A phantomjs cache would make a lot of sense for resources.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Ok, or do a version against JBoss Developer and put it in a PR?

pmuir commented on pull request pmuir/blinkr#12
@pmuir

What I'm asking is whether doing a HEAD AND a GET for those that need it is faster than always just doing a GET.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Ok, can you add that back in then?

pmuir commented on pull request pmuir/blinkr#12
@pmuir

This was the single mode. Yes, I used it.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

When I was running with Typhoeus instead of PhantomJS things were blowing up because it wasn't actually created, IIRC. I don't really understand …

pmuir commented on pull request pmuir/blinkr#12
@pmuir

This makes sense too.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

This looks good, I never managed to get the cache to work.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

It will be easier to check the report if you have a preview.

pmuir commented on pull request pmuir/blinkr#12
@pmuir

Does this speed things up?