Skip to content

TypeScript Router.fetchMarketMatches missing query and category params present in Python #175

@realfishsam

Description

@realfishsam

Drift

Python Router.fetch_market_matches accepts query and category parameters for browse-mode market matching. The TypeScript Router.fetchMarketMatches overload signatures do not include these parameters.

TypeScript SDK

sdks/typescript/pmxt/router.ts, lines 139–149:

async fetchMarketMatches(params?: {
    market?: UnifiedMarket;
    marketId?: string;
    slug?: string;
    url?: string;
    relation?: MatchRelation;
    minConfidence?: number;
    limit?: number;
    includePrices?: boolean;
    // query    — missing
    // category — missing
}): Promise<MatchResult[]>

Python SDK

sdks/python/pmxt/router.py, lines 97–110:

def fetch_market_matches(
    self,
    market: Optional[UnifiedMarket] = None,
    *,
    market_id: Optional[str] = None,
    slug: Optional[str] = None,
    url: Optional[str] = None,
    query: Optional[str] = None,      # ← only in Python
    category: Optional[str] = None,   # ← only in Python
    relation: Optional[MatchRelation] = None,
    min_confidence: Optional[float] = None,
    limit: Optional[int] = None,
    include_prices: bool = False,
) -> List[MatchResult]:

Expected

TypeScript Router.fetchMarketMatches should add query?: string and category?: string to its params object to match the Python signature.

Impact

Python users can browse cross-venue matches by free-text query or category without having a specific market object. TypeScript users cannot pass these parameters through the typed interface.


Found by automated SDK cross-language drift audit

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions