You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the Opinion exchange base URL from openapi.opinion.trade/openapi to proxy.opinion.trade:8443/openapi across all three layers: the vendor OpenAPI spec, the generated api.ts, and the config.ts default constant. Also updates the changelog to reflect the new URL.
Merge conflict with PR fix: add env fallbacks for hardcoded service URLs #589: PR 589 wraps the same DEFAULT_OPINION_API_URL in process.env.OPINION_API_URL || .... If PR 589 merges first, this PR must update the fallback URL inside the env var expression. If this PR merges first, PR 589 needs to wrap the new URL. Either way, manual conflict resolution is needed.
WebSocket URL not updated: The REST base URL moves from openapi.opinion.trade to proxy.opinion.trade:8443, but OPINION_WS_URL still points to wss://ws.opinion.trade. If the proxy also handles WebSocket traffic, this may need updating. If the WS endpoint remains on the original host, this is fine -- but it should be verified.
All three layers are correctly updated -- spec, api.ts, and config.ts are consistent with the new URL. The changelog documents the change. This is a clean URL migration.
PMXT Pipeline Check
Field propagation: N/A
OpenAPI sync: OK (api.ts matches spec)
Type safety: N/A
Semver Impact
patch -- URL migration, no API shape change.
Risk
WebSocket URL may also need updating (unverified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #516