Rename firstUUIDForTime() / lastUUIDForTime #4

Closed
ctavan opened this Issue Nov 12, 2011 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

ctavan commented Nov 12, 2011

To get the API a bit more consistent I suggest renaming firstUUIDForTime() to firstFromTime() and lastUUIDForTime() to lastFromTime() since both are methods of the UUID object anyways, so the UUID in the method name is somehow superfluous.

This would also be more consistent with the third method fromTime() that these two methods are only wrappers for.

Owner

pnegri commented Nov 13, 2011

Checked actual dependancies and can be done.

Contributor

ctavan commented Nov 13, 2011

So this means you don't even need the old method names?

ctavan added a commit to ctavan/uuid-js that referenced this issue Nov 13, 2011

Owner

pnegri commented Nov 13, 2011

Sure, we dont. Its not being use anywhere, yet.

@pnegri pnegri closed this in 8bee754 Nov 13, 2011

ctavan added a commit to ctavan/uuid-js that referenced this issue Nov 13, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment