Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic twitterpic #60

Merged
merged 3 commits into from Aug 21, 2018
Merged

Generic twitterpic #60

merged 3 commits into from Aug 21, 2018

Conversation

@PopWarner
Copy link
Contributor

@PopWarner PopWarner commented Jul 24, 2018

Q A
Bug fix? yes
New sample? no
Related issues? fixes potential issue with Twitter URL

What's in this Pull Request?

Updated the ReadMe to document an alternative to using a direct Twitter request for the Twitter Pic. The Twitter image URL returns a 403 when logged into Twitter in the same browsing session as the SharePoint connection.

Guidance

Documented alternative Twitter pic URL service to prevent 403 error being returned from Twitter under certain circumstances.

Thanks for your contribution! Sharing is caring.

@thechriskent thechriskent self-assigned this Jul 26, 2018
@thechriskent thechriskent merged commit ccd3ae7 into pnp:master Aug 21, 2018
1 check passed
@thechriskent
Copy link
Contributor

@thechriskent thechriskent commented Aug 21, 2018

Thanks, this is great feedback. I'm going to leave this alongside your social sample for now, but we may just eliminate this one in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants