Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Pr1008 #1054

Merged
merged 7 commits into from Sep 7, 2017
Merged

Pr1008 #1054

merged 7 commits into from Sep 7, 2017

Conversation

erwinvanhunen
Copy link
Member

Manual merge and updates to PR #1008.

@erwinvanhunen erwinvanhunen merged commit b94efa1 into pnp:dev Sep 7, 2017
@ypcode
Copy link
Contributor

ypcode commented Sep 8, 2017

Hi @erwinvanhunen ,

I noticed a strange thing in the generated doc of the AddPnPClientSidePage cmdlet (https://github.com/SharePoint/PnP-PowerShell/blob/dev/Documentation/AddPnPClientSidePage.md)
It's due to the CommentsEnabled argument that is a nullable boolean.
Should we go for another parameter type? or could the doc be fixed ?

addclientsidepage-cmdlet-doc

@ypcode
Copy link
Contributor

ypcode commented Sep 8, 2017

Actually brought some typo fixing and changed this boolean thing to SwitchParameter in the PR #1062

@erwinvanhunen erwinvanhunen deleted the PR1008 branch November 4, 2017 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants