Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Fixes typos in documentation + changed the CommentsEnabled argument type #1062

Merged
merged 3 commits into from Oct 4, 2017

Conversation

ypcode
Copy link
Contributor

@ypcode ypcode commented Sep 8, 2017

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes typos and documentation mismatch in PR #1054

What is in this Pull Request ?

  • Fixes typos, docs mismatch and improve consistency across Doc examples
  • Converted CommentsEnabled argument to be a switch parameter instead of a nullable boolean
  • The AddPnPClientSidePage cmdlet has now the Name argument as first position (It allows to use "Add-PnPClientSidePage "mypage" )
  • Ensures the ClientSidePagePipeBind has always a value for the _name field. When the piped object is a ClientSidePage object, the name of the underlying file is fetched.

@ypcode ypcode mentioned this pull request Sep 8, 2017
@ypcode
Copy link
Contributor Author

ypcode commented Sep 8, 2017

@erwinvanhunen I have a little question here.
Why are the -Section and -Column of the AddClientSideText and AddClientSideWebPart are narked as mandatory since it is, functionally speaking, not mandatory to set the position of the component ?

[EDIT] Nevermind, I just got up to speed with the ParameterSetName attribute ;)

@erwinvanhunen
Copy link
Member

erwinvanhunen commented Oct 4, 2017

Good fixes!

@erwinvanhunen erwinvanhunen merged commit 273bf7e into pnp:dev Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants