Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Fixes typos in documentation + changed the CommentsEnabled argument type#1062

Merged
erwinvanhunen merged 3 commits into
pnp:devfrom
ypcode:dev-clientsidepages-fixes
Oct 4, 2017
Merged

Fixes typos in documentation + changed the CommentsEnabled argument type#1062
erwinvanhunen merged 3 commits into
pnp:devfrom
ypcode:dev-clientsidepages-fixes

Conversation

@ypcode

@ypcode ypcode commented Sep 8, 2017

Copy link
Copy Markdown
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes typos and documentation mismatch in PR #1054

What is in this Pull Request ?

  • Fixes typos, docs mismatch and improve consistency across Doc examples
  • Converted CommentsEnabled argument to be a switch parameter instead of a nullable boolean
  • The AddPnPClientSidePage cmdlet has now the Name argument as first position (It allows to use "Add-PnPClientSidePage "mypage" )
  • Ensures the ClientSidePagePipeBind has always a value for the _name field. When the piped object is a ClientSidePage object, the name of the underlying file is fetched.

@ypcode ypcode mentioned this pull request Sep 8, 2017
@ypcode

ypcode commented Sep 8, 2017

Copy link
Copy Markdown
Contributor Author

@erwinvanhunen I have a little question here.
Why are the -Section and -Column of the AddClientSideText and AddClientSideWebPart are narked as mandatory since it is, functionally speaking, not mandatory to set the position of the component ?

[EDIT] Nevermind, I just got up to speed with the ParameterSetName attribute ;)

@erwinvanhunen

Copy link
Copy Markdown
Member

Good fixes!

@erwinvanhunen erwinvanhunen merged commit 273bf7e into pnp:dev Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants