Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Fixes inconsistencies in Add-PnPCustomAction cmdlet parameters#1080

Merged
erwinvanhunen merged 1 commit into
pnp:devfrom
ypcode:dev-customaction-improvements
Oct 4, 2017
Merged

Fixes inconsistencies in Add-PnPCustomAction cmdlet parameters#1080
erwinvanhunen merged 1 commit into
pnp:devfrom
ypcode:dev-customaction-improvements

Conversation

@ypcode

@ypcode ypcode commented Sep 12, 2017

Copy link
Copy Markdown
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

What is in this Pull Request ?

The Add-PnPCustomAction cmdlet allows to add a custom action to associate with SPFx extensions through the ClientSideComponentId.

  • The ClientSideComponentProperties, however, are not required
  • For the ListviewCommandSet extension, we need to set the RegistrationId and RegistrationType parameters that were not included in the ParameterSet.

This PR fixes those two "issues"

@erwinvanhunen

Copy link
Copy Markdown
Member

Good ones! Thanks!

@erwinvanhunen erwinvanhunen merged commit 1d28e73 into pnp:dev Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants