Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Add List Extensions methods to manage Webhooks subscriptions#1197

Merged
jansenbe merged 2 commits into
pnp:devfrom
ypcode:list-webhooks-subscriptions
Jun 7, 2017
Merged

Add List Extensions methods to manage Webhooks subscriptions#1197
jansenbe merged 2 commits into
pnp:devfrom
ypcode:list-webhooks-subscriptions

Conversation

@ypcode

@ypcode ypcode commented May 21, 2017

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? yes
New sample? no

What's in this Pull Request?

List Extension methods to manage List Webhooks subscriptions and all the underlying utilities + related unit tests

@msftclas

Copy link
Copy Markdown

@ypcode,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@ypcode ypcode changed the title Add List Extensions methods for manager Webhooks subscriptions Add List Extensions methods to manage Webhooks subscriptions May 21, 2017
@VesaJuvonen

Copy link
Copy Markdown
Contributor

Hi Yannick,
please remember to sign the CLA at https://cla.microsoft.com. Submission looks good with quick check, but we'll have a closer look on upcoming days. Thx.

@ypcode

ypcode commented Jun 2, 2017

Copy link
Copy Markdown
Contributor Author

Hi @VesaJuvonen, I actually did sign it, and I have a copy the signed document, I was expecting this status to change automatically, I'll redo it ;)

@jansenbe jansenbe merged commit bbfac46 into pnp:dev Jun 7, 2017
@jansenbe

jansenbe commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

Thanks @ypcode, you did a great job on the PR. I've merged your PR but also did some additions and refactoring.

@ypcode

ypcode commented Jun 7, 2017

Copy link
Copy Markdown
Contributor Author

You're welcome ;) It's a great honnor to bring my modest contribution to this project ! I plan to do a lot more.

By the way, Can somebody tell me why the CLA is still pending ? I sent an email to the support address but no response yet...

@ypcode ypcode deleted the list-webhooks-subscriptions branch June 7, 2017 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants