Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Refresh Token bug fix in WebAPI Helper#1371

Merged
jansenbe merged 2 commits into
pnp:devfrom
ypcode:dev-fix-webapi
Oct 5, 2017
Merged

Refresh Token bug fix in WebAPI Helper#1371
jansenbe merged 2 commits into
pnp:devfrom
ypcode:dev-fix-webapi

Conversation

@ypcode

@ypcode ypcode commented Sep 28, 2017

Copy link
Copy Markdown
Contributor
Q A
Bug fix? yes
New feature? no
New sample? no

What's in this Pull Request?

Fixes the condition to refresh the access token in the WebAPI Helper
The Token was refreshed only after expiration+ one hour

@jansenbe jansenbe self-assigned this Sep 28, 2017
@ypcode

ypcode commented Sep 29, 2017

Copy link
Copy Markdown
Contributor Author

Hello @jansenbe,
In some docs, I read the ACS access token was initial valid for 12 hours but this could vary.
In Azure AD tokens, I read it is valid for only one hour. I was wondering if it has become the same for ACS tokens (because, in the logs of my customer application, I see it continously refreshes the token and the expiry date seems to be no more than 1 hour.

That would mean this condition I fixed here is no longer relevant.
Any thoughts about it ?

@jansenbe

jansenbe commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

Think token lifetime (is) will be configurable, so this still makes sense.

@jansenbe jansenbe merged commit e521617 into pnp:dev Oct 5, 2017
@ypcode ypcode deleted the dev-fix-webapi branch January 1, 2018 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants