Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Refresh Token bug fix in WebAPI Helper #1371

Merged
merged 2 commits into from Oct 5, 2017
Merged

Conversation

ypcode
Copy link
Contributor

@ypcode ypcode commented Sep 28, 2017

Q A
Bug fix? yes
New feature? no
New sample? no

What's in this Pull Request?

Fixes the condition to refresh the access token in the WebAPI Helper
The Token was refreshed only after expiration+ one hour

@jansenbe jansenbe self-assigned this Sep 28, 2017
@ypcode
Copy link
Contributor Author

ypcode commented Sep 29, 2017

Hello @jansenbe,
In some docs, I read the ACS access token was initial valid for 12 hours but this could vary.
In Azure AD tokens, I read it is valid for only one hour. I was wondering if it has become the same for ACS tokens (because, in the logs of my customer application, I see it continously refreshes the token and the expiry date seems to be no more than 1 hour.

That would mean this condition I fixed here is no longer relevant.
Any thoughts about it ?

@jansenbe
Copy link
Contributor

jansenbe commented Oct 5, 2017

Think token lifetime (is) will be configurable, so this still makes sense.

@jansenbe jansenbe merged commit e521617 into pnp:dev Oct 5, 2017
@ypcode ypcode deleted the dev-fix-webapi branch Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants