Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Move chalk.green('DONE') outside of the commandAction #2045

Closed
waldekmastykarz opened this issue Jan 8, 2021 · 0 comments
Closed

Enhancement: Move chalk.green('DONE') outside of the commandAction #2045

waldekmastykarz opened this issue Jan 8, 2021 · 0 comments
Assignees
@waldekmastykarz
Labels
enhancement work in progress
Milestone
v3.6

Comments

@waldekmastykarz
Copy link
Member

Currently, in our commands we output in verbose mode chalk.green('DONE') to confirm that the command has completed its execution. We implement this separately in each command. To improve consistency and simplify our code base, we should move it outside commandAction so that it's executed centrally and for each command without us having to think twice about implementing it. An added benefit is, that it will help us simplify our tests.
@waldekmastykarz waldekmastykarz self-assigned this Jan 29, 2021
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jan 30, 2021
@waldekmastykarz
Moves 'DONE' out of the commandAction. Closes pnp#2045
9eabe63
@waldekmastykarz waldekmastykarz mentioned this issue Jan 30, 2021
Closed
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jan 30, 2021
@waldekmastykarz
Moves 'DONE' out of the commandAction. Closes pnp#2045
3f6eb95
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jan 31, 2021
@waldekmastykarz
Moves 'DONE' out of the commandAction. Closes pnp#2045
02dda76
waldekmastykarz added a commit to waldekmastykarz/cli-microsoft365 that referenced this issue Jan 31, 2021
@waldekmastykarz
Moves 'DONE' out of the commandAction. Closes pnp#2045
b21863e
@waldekmastykarz waldekmastykarz added this to the v3.6 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waldekmastykarz waldekmastykarz

Labels
enhancement work in progress
Projects
None yet
Milestone
v3.6
Development

Successfully merging a pull request may close this issue.

Moves 'DONE' out of the commandAction. Closes #2045 waldekmastykarz/cli-microsoft365
1 participant
@waldekmastykarz