Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In spfx project upgrade don't suggest removing .editorconfig #3126

Closed
waldekmastykarz opened this issue Mar 11, 2022 Discussed in #3122 · 3 comments
Closed

In spfx project upgrade don't suggest removing .editorconfig #3126

waldekmastykarz opened this issue Mar 11, 2022 Discussed in #3122 · 3 comments
Assignees
@Jwaegebaert
Labels
bug work in progress
Milestone
v5.1

Comments

@waldekmastykarz
Copy link
Member

Discussed in #3122

Why does the project upgrade command suggest removing .editorconfig?

Originally posted by pschaeflein March 10, 2022
@Jwaegebaert
Copy link
Contributor

Could I work on this one?

@waldekmastykarz
Copy link
Member Author

Please do!

@Jwaegebaert
Copy link
Contributor

Jwaegebaert commented Mar 15, 2022 •
edited

If I am not mistaken, this is only requested when upgrading to version 1.12.0. Currently I have removed this suggestion from here. So when the user has an .editorconfig file. It will just be ignored. I will open a PR soon so you can see the changes I did.

@Jwaegebaert Jwaegebaert mentioned this issue Mar 15, 2022
Closed
@waldekmastykarz waldekmastykarz added this to the v5.1 milestone Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jwaegebaert Jwaegebaert

Labels
bug work in progress
Projects
None yet
Milestone
v5.1
Development

Successfully merging a pull request may close this issue.

Fixes spfx project upgrade command. Closes #3126 Jwaegebaert/cli-microsoft365
2 participants
@waldekmastykarz @Jwaegebaert