Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
New command: add client-side web part to modern page #366
Add client-side web part to modern page
For more information see the Add-PnPClientSideWebPart cmdlet.
good first issue
good first issue
Mar 13, 2018
Actually, If I go with the existing @pnp/js methods, that would be fine, I'll come up with something, just tell me if I need to espcially care about anything :)
[EDIT] I just noticed the @pnp/js is not in the dependencies, is there a will not to use it, or just that is not been used yet?
@ypcode we're trying to keep the dependencies to the minimum and have consistent implementation across all commands. We borrowed some code from PnPJS for parsing the field contents but not for calling the API, that will stay implemented as a REST call.
Perfect, I will copy the needed code then, will first dig into several commands to follow the conventions and reuse what could be :) Cordialement Yannick Plenevaux…
________________________________ From: Waldek Mastykarz <firstname.lastname@example.org> Sent: Wednesday, June 20, 2018 5:58:30 PM To: pnp/office365-cli Cc: Yannick Plenevaux; Mention Subject: Re: [pnp/office365-cli] New command: add client-side web part to modern page (#366) Regarding #364<#364>, I don't think you'd need to wait for the implementation of that command. Using the available pieces, you should be able to implement this command by itself. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#366 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH9X1IgrrwafsxxNZyKZUSdydk43xPvXks5t-nElgaJpZM4SpRNi>.