Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for setting CSOM properties on web solving #1202 #1208

Closed
wants to merge 1 commit into from

Conversation

@waldekmastykarz
Copy link
Member

waldekmastykarz commented Nov 26, 2019

Added support for setting CSOM properties on web solving #1202

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 562af97 on waldekmastykarz:csom-web into 3042bbe on pnp:dev.

Copy link
Collaborator

VelinGeorgiev left a comment

Lol @waldekmastykarz, this is magic! Very nice move.

MAGIC!

Maybe we can create a separate article under the concepts section to explain how this works, just for a little more visibility.

@VelinGeorgiev VelinGeorgiev removed their assignment Nov 29, 2019
@waldekmastykarz

This comment has been minimized.

Copy link
Member Author

waldekmastykarz commented Nov 29, 2019

Good idea @VelinGeorgiev! Let's create a separate issue related to docs so that we can track it.

@waldekmastykarz

This comment has been minimized.

Copy link
Member Author

waldekmastykarz commented Dec 2, 2019

Merged manually.

@waldekmastykarz waldekmastykarz deleted the waldekmastykarz:csom-web branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.