Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams app publish and update commands #829

Closed
wants to merge 4 commits into
base: dev
from

Conversation

Projects
None yet
3 participants
@estruyf
Copy link
Collaborator

estruyf commented Feb 24, 2019

This PR contains the commands to publish and update Teams app to your organization's app catalog.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling c56b5c1 on estruyf:teams-app-publish into 6200f63 on pnp:dev.

@waldekmastykarz

This comment has been minimized.

Copy link
Member

waldekmastykarz commented Feb 24, 2019

Thanks! I'll have a look asap!

@waldekmastykarz
Copy link
Member

waldekmastykarz left a comment

Nicely done with some fixes which I've done when merging the PR.

filePath: string;
}

class TeamsAppPublishCommand extends GraphItemsListCommand<Team> {

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Since this command is not listing any contents, it should inherit from the GraphCommand base class.

return 'Publish Teams app to your organization\'s app catalog';
}

public getTelemetryProperties(args: CommandArgs): any {

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

We can remove this because we're not tracking any properties in this command

if (!args.options.filePath) {
return 'Missing required option filePath';
}

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Here we should also check if the specified path exists and points to a file

}

cb();
}, (rawRes: any): void => this.handleRejectedODataPromise(rawRes, cmd, cb));

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Because we accept JSON content in the response we should use the handleRejectedODataJsonPromise error handling method to correctly parse error response

@@ -0,0 +1,36 @@
# teams app publish

Publishes a Teams app to the oranization's app catalog

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Typo in organization

Option|Description
------|-----------
`--help`|output usage information
`-i, --id <id>`|ID of the app to upgrade

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Should be update instead of upgrade

!!! important
Before using this command, log in to the Microsoft Graph, using the [graph login](../login.md) command.

### Remarks

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Remarks is a level 2-heading


### Remarks

To update a Teams app file to your organzation's app catalog, you have to first log in to the Microsoft Graph using the [graph login](../login.md) command, eg. `graph login`.

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Different than the help in the command


To update a Teams app file to your organzation's app catalog, you have to first log in to the Microsoft Graph using the [graph login](../login.md) command, eg. `graph login`.

You can only update a Teams app as a global administrator.

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Missing in command's help


## Examples

Update an existing Teams app

This comment has been minimized.

@waldekmastykarz

waldekmastykarz Feb 25, 2019

Member

Different than the example in the command's help

@waldekmastykarz

This comment has been minimized.

Copy link
Member

waldekmastykarz commented Feb 25, 2019

Merged manually. Thanks! Cool stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.