Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for $expand in getAll (items.expand('...')) #33

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@eirikb
Copy link
Contributor

commented Mar 9, 2018

This fix adds support for expand by adding it to list of keys
copied from this.query.

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?
  • Feature enhancement?

What's in this Pull Request?

This PR add support for expand to the new getAll method.
We discussed this on gitter, and I understand that expand was deliberately excluded from getAll because of performance reasons.
While I understand the decision I still would like the ability to get all data in the exact same was as with items.get().

The reason I want this is that we often use pnp for small snippets (using tick), and then we need to run expand to do one-time jobs where we need more data, even if they are slow.

Add support for $expand in getAll (items.expand('...'))
This fix adds support for expand by adding it to list of keys
copied from `this.query`.
@patrick-rodgers

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

Thanks! Got you added to the authors file as well.

@patrick-rodgers patrick-rodgers merged commit d742b1f into pnp:dev Mar 9, 2018

@patrick-rodgers patrick-rodgers added this to the 1.0.4 milestone Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.