Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@pnp/graph: Added support for me/onenote/notebooks #37

Merged
merged 2 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@olemp
Copy link
Contributor

commented Mar 9, 2018

Category

  • Bug fix
  • New feature
  • New sample
  • Documentation update

What's in this Pull Request?

Support for me/onenote/notebooks

@patrick-rodgers

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

So this PR and #38 now have conflicts based on #32. Do you want to update your PRs to fix those conflicts?

@patrick-rodgers patrick-rodgers added this to the 1.0.4 milestone Mar 9, 2018

@patrick-rodgers patrick-rodgers self-assigned this Mar 9, 2018

@olemp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2018

I'll take a look on monday @patrick-rodgers 🍔

@olemp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

FIxed 🔨

@patrick-rodgers

This comment has been minimized.

Copy link
Member

commented Mar 13, 2018

Thanks, will get this merged shortly!

@patrick-rodgers

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

Were you able to test the add notebook method successfully? I am trying as part of the merge and keep getting back errors. Not sure it is this code as much as a service issue.

[Edit] - I figured out my problem, but am still curious if you were able to successful test?

@patrick-rodgers patrick-rodgers merged commit 2035ea2 into pnp:dev Mar 16, 2018

@olemp olemp deleted the olemp:me-onenote-notebooks branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.