From 071e783eaf4f06f3f1bb2ec48a3a052bb9747794 Mon Sep 17 00:00:00 2001 From: Koen Zomers Date: Fri, 13 Jan 2023 00:48:52 +0100 Subject: [PATCH 1/3] Marked `Get-PnPSubscribeSharePointNewsDigest` and `Set-PnPSubscribeSharePointNewsDigest` as obsolete --- CHANGELOG.md | 1 + documentation/Get-PnPSubscribeSharePointNewsDigest.md | 2 ++ documentation/Set-PnPSubscribeSharePointNewsDigest.md | 2 ++ src/Commands/UserProfiles/GetSubscribeSharePointNewsDigest.cs | 2 ++ src/Commands/UserProfiles/SetSubscribeSharePointNewsDigest.cs | 2 ++ 5 files changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dcbbf3e8..14bb97efa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Improved `Register-PnPAzureADApp` cmdlet based on compiler warnings. [#2682](https://github.com/pnp/powershell/pull/2682) - `Connect-PnPOnline` will now throw a much clearer error message if the site to be connected doesn't exist when using the legacy Client Id with Secret (ACS) authentication mode. [#2707](https://github.com/pnp/powershell/pull/2707) - Properties of `Get-PnPAzureADServicePrincipal` are now all typed instead of some of them returning unparsed JSON fragments +- Marked `Get-PnPSubscribeSharePointNewsDigest` and `Set-PnPSubscribeSharePointNewsDigest` as obsolete as the implementation behind these feates has been changed in SharePoint Online causing them no longer to work. At present there's no alternative for this that we can call into thus we will have to remove these in a future version. ### Removed diff --git a/documentation/Get-PnPSubscribeSharePointNewsDigest.md b/documentation/Get-PnPSubscribeSharePointNewsDigest.md index 79e828244..1ea88dc28 100644 --- a/documentation/Get-PnPSubscribeSharePointNewsDigest.md +++ b/documentation/Get-PnPSubscribeSharePointNewsDigest.md @@ -19,6 +19,8 @@ You must connect to the tenant admin website (https://tenant-admin.sharepoint.co Retrieves if the SharePoint News Digest mails are enabled or disabled for a particular user. +Note: The impementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. + ## SYNTAX ```powershell diff --git a/documentation/Set-PnPSubscribeSharePointNewsDigest.md b/documentation/Set-PnPSubscribeSharePointNewsDigest.md index 35b7157ac..2d2370d31 100644 --- a/documentation/Set-PnPSubscribeSharePointNewsDigest.md +++ b/documentation/Set-PnPSubscribeSharePointNewsDigest.md @@ -19,6 +19,8 @@ You must connect to the tenant admin website (https://tenant-admin.sharepoint.co Enables or disables the SharePoint News Digest mails for a particular user. Note that the disabling option is still experimental and may not work and may be removed again in the future. +Note: The impementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. + ## SYNTAX ```powershell diff --git a/src/Commands/UserProfiles/GetSubscribeSharePointNewsDigest.cs b/src/Commands/UserProfiles/GetSubscribeSharePointNewsDigest.cs index 4f1ee8af6..571842d7c 100644 --- a/src/Commands/UserProfiles/GetSubscribeSharePointNewsDigest.cs +++ b/src/Commands/UserProfiles/GetSubscribeSharePointNewsDigest.cs @@ -5,11 +5,13 @@ using PnP.PowerShell.Commands.Base; using PnP.PowerShell.Commands.Model; +using System; namespace PnP.PowerShell.Commands.UserProfiles { [Cmdlet(VerbsCommon.Get, "PnPSubscribeSharePointNewsDigest")] [OutputType(typeof(SubscribeSharePointNewsDigestStatus))] + [Obsolete("The implementation behind this feature has changed in SharePoint Online making it impossible at the moment to call this using PnP PowerShell. This cmdlet therefore no longer works and will be removed in a future version.")] public class GetSubscribeSharePointNewsDigest : PnPAdminCmdlet { [Parameter(Mandatory = true, Position = 0)] diff --git a/src/Commands/UserProfiles/SetSubscribeSharePointNewsDigest.cs b/src/Commands/UserProfiles/SetSubscribeSharePointNewsDigest.cs index d894f8d21..21a67a50f 100644 --- a/src/Commands/UserProfiles/SetSubscribeSharePointNewsDigest.cs +++ b/src/Commands/UserProfiles/SetSubscribeSharePointNewsDigest.cs @@ -5,11 +5,13 @@ using PnP.PowerShell.Commands.Base; using PnP.PowerShell.Commands.Model; +using System; namespace PnP.PowerShell.Commands.UserProfiles { [Cmdlet(VerbsCommon.Set, "PnPSubscribeSharePointNewsDigest")] [OutputType(typeof(string))] + [Obsolete("The implementation behind this feature has changed in SharePoint Online making it impossible at the moment to call this using PnP PowerShell. This cmdlet therefore no longer works and will be removed in a future version.")] public class SetSubscribeSharePointNewsDigest : PnPAdminCmdlet { [Parameter(Mandatory = true, Position = 0)] From 5d16e68321f0eeb75b0ba1acefeeb1237abd3b7a Mon Sep 17 00:00:00 2001 From: Koen Zomers Date: Fri, 13 Jan 2023 00:50:15 +0100 Subject: [PATCH 2/3] Typo fix --- documentation/Get-PnPSubscribeSharePointNewsDigest.md | 2 +- documentation/Set-PnPSubscribeSharePointNewsDigest.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/documentation/Get-PnPSubscribeSharePointNewsDigest.md b/documentation/Get-PnPSubscribeSharePointNewsDigest.md index 1ea88dc28..96380a7fe 100644 --- a/documentation/Get-PnPSubscribeSharePointNewsDigest.md +++ b/documentation/Get-PnPSubscribeSharePointNewsDigest.md @@ -19,7 +19,7 @@ You must connect to the tenant admin website (https://tenant-admin.sharepoint.co Retrieves if the SharePoint News Digest mails are enabled or disabled for a particular user. -Note: The impementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. +Note: The implementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. ## SYNTAX diff --git a/documentation/Set-PnPSubscribeSharePointNewsDigest.md b/documentation/Set-PnPSubscribeSharePointNewsDigest.md index 2d2370d31..2699a1809 100644 --- a/documentation/Set-PnPSubscribeSharePointNewsDigest.md +++ b/documentation/Set-PnPSubscribeSharePointNewsDigest.md @@ -19,7 +19,7 @@ You must connect to the tenant admin website (https://tenant-admin.sharepoint.co Enables or disables the SharePoint News Digest mails for a particular user. Note that the disabling option is still experimental and may not work and may be removed again in the future. -Note: The impementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. +Note: The implementation behind this in SharePoint Online has changed causing this cmdlet to no longer work. Unfortunately there's no alternative way to call into this functionality from PnP PowerShell. We therefore have to remove this cmdlet in a future version. At present it does not work anymore. ## SYNTAX From 19b360470d88ae938469d3d2b13a807ca6da8396 Mon Sep 17 00:00:00 2001 From: Koen Zomers Date: Fri, 13 Jan 2023 00:58:52 +0100 Subject: [PATCH 3/3] Added PR reference --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 14bb97efa..61ad5f6ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,7 +39,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Improved `Register-PnPAzureADApp` cmdlet based on compiler warnings. [#2682](https://github.com/pnp/powershell/pull/2682) - `Connect-PnPOnline` will now throw a much clearer error message if the site to be connected doesn't exist when using the legacy Client Id with Secret (ACS) authentication mode. [#2707](https://github.com/pnp/powershell/pull/2707) - Properties of `Get-PnPAzureADServicePrincipal` are now all typed instead of some of them returning unparsed JSON fragments -- Marked `Get-PnPSubscribeSharePointNewsDigest` and `Set-PnPSubscribeSharePointNewsDigest` as obsolete as the implementation behind these feates has been changed in SharePoint Online causing them no longer to work. At present there's no alternative for this that we can call into thus we will have to remove these in a future version. +- Marked `Get-PnPSubscribeSharePointNewsDigest` and `Set-PnPSubscribeSharePointNewsDigest` as obsolete as the implementation behind these feates has been changed in SharePoint Online causing them no longer to work. At present there's no alternative for this that we can call into thus we will have to remove these in a future version. [#2720](https://github.com/pnp/powershell/pull/2720) ### Removed