Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the react-graph-latest-client sample #1826

Conversation

sebastienlevert
Copy link
Contributor

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? none, yet

What's in this Pull Request?

Adding the new react-graph-latest-client sample to promote how to use MGT to get the latest version of the Graph client and leverage the middleware options

@hugoabernier
Copy link
Collaborator

Hey @sebastienlevert thanks for this sample. As per some of the comments on Twitter, how would you feel about renaming the sample react-graph-mgt-middleware or something like that? I think it is perfectly fine to rename the sample folder and README only, the solution can stay the same name.

Let me know and I can rename the folder when I merge.

@sebastienlevert
Copy link
Contributor Author

sebastienlevert commented Apr 19, 2021

What about react-graph-mgt-client? I think it makes more sense as it's more than just the middlewares. Thanks! I can definitely do the renaming if you need, not an issue!

@sebastienlevert
Copy link
Contributor Author

Renamed just happened! I settled on react-graph-mgt-client

@hugoabernier hugoabernier merged commit 0d231f9 into pnp:master Apr 22, 2021
@hugoabernier
Copy link
Collaborator

Wow, super cool @sebastienlevert! How would you feel about demoing this web part on the May 20th SPFx community call?

@sebastienlevert
Copy link
Contributor Author

Count me in @hugoabernier! Absolutely possible, it'll be fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants