Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Example of using Angular 2 with API Pokemon API #30

Closed
wants to merge 2 commits into from

Conversation

AdrianDiaz81
Copy link

Q A
Bug fix? no - yes?
New feature? no - yes?
New sample? no - yes?
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Guidance

You can delete this section when you are submitting the pull request.

  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to Dev branch.

Thanks for your contribution! Sharing is caring.

@msftclas
Copy link

msftclas commented Oct 5, 2016

Hi @AdrianDiaz81, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@AdrianDiaz81
Copy link
Author

I just signed the agreement ;)

@msftclas
Copy link

msftclas commented Oct 5, 2016

@AdrianDiaz81, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@VesaJuvonen
Copy link
Contributor

Hi Adrian,
could you resubmit this and target 'dev' branch. We do gradual master merges with this repository and would like to get all contributions to 'dev' branch, like explained in Contribution Guidance documentation here - https://github.com/SharePoint/sp-dev-fx-webparts/blob/master/.github/CONTRIBUTING.md.

Would also update the README based on the guidance details with the provided template. Contribution Guidance document has all the details.

thx.

@VesaJuvonen
Copy link
Contributor

Just additional note. I'll close this for now and you can hopefully resubmit the PR towards 'dev' branch. Thx for your contribution advance.

@VesaJuvonen VesaJuvonen closed this Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants