Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated angular2-prototype sample to RC0 #99

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

s-KaiNet
Copy link
Contributor

Q A
New feature? yes

As title says, angular2-prototype sample fixed to support RC0.
Actually not fixed, but rebuilt from ground using yo's "No javascript web framework" (it's easier to rebuild because a lot of changes were introduced in RC0).

Also changed "hack" to grab instance of root ng2 component (no longer works):
this._component = this._app['_rootComponents'][0]['_hostElement']['component'];
to
this._component = this._app['_rootComponents'][0].instance;
which is seems to be working.

@msftclas
Copy link

Hi @s-KaiNet, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@VesaJuvonen
Copy link
Contributor

thx Sergei, appreciated. Good to get this to RC level as well.

@VesaJuvonen VesaJuvonen merged commit 27b2672 into pnp:dev Feb 3, 2017
@s-KaiNet s-KaiNet deleted the fix-ng2-rc0 branch February 5, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants