Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Correct the VS Code extension name in assets images #225

Closed
Adam-it opened this issue Apr 17, 2024 · 7 comments · Fixed by #296
Closed

💡 [Feature]: Correct the VS Code extension name in assets images #225

Adam-it opened this issue Apr 17, 2024 · 7 comments · Fixed by #296
Assignees
@tmaestrini
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone
v3.X

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Apr 17, 2024

🎯 Aim of the feature

Go over the assets images and sort out the naming so that it will be SharePoint Framework Toolkit in every image

📷 Images (if possible) with expected result

example image taken from the readme with this problem

image

🤔 Additional remarks or comments

No response
@Adam-it Adam-it added ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Apr 17, 2024
@Adam-it Adam-it added this to the v3.X milestone Apr 17, 2024
@tmaestrini
Copy link

I'm interested in being assigned… That's a good starting point! :)

@Adam-it
Copy link
Contributor Author

Adam-it commented Apr 18, 2024

Awesome! All yours

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Apr 18, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Apr 18, 2024

@tmaestrini so to maybe give you some more context or info that might be helpful to resolve this issue:

  • all of the images may be found in assets/images location
  • if you will need to recreate the images from scratch please do be aware that:
    • the primary color of SPFx Toolkit is #2A777C which should be used in text areas and arrows
    • we should use default Light + VS Code theme when creating images

image

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 7, 2024

@tmaestrini it has been a while. Do you want to continue working on this or would you like to open it up for the community?

@tmaestrini
Copy link

tmaestrini commented Jul 8, 2024 •
edited
Loading

Hey @Adam-it, I definitely would love to work on it! 💪 I haven't had time yet, that wasn't intentional! Sorry! 🙏

@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 8, 2024

Hey @Adam-it, I definitely would love to work on it! 💪 I haven't had time yet, that wasn't intentional! Sorry! 🙏

No problem. Keeping it for you then 👍

@Adam-it Adam-it linked a pull request Sep 7, 2024 that will close this issue
Updates Sign in method. Closes: #291, #266, #265, #225 #296
Merged
6 tasks
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
d79ac32 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
@Adam-it
Copy link
Contributor Author

Adam-it commented Sep 8, 2024

@tmaestrini I corrected the images in the readme along a bigger change I merged to dev just now. This should be release (I hope) today.
Thank you once again for taking an interest in this repository 👍. If you still want to help out there are plenty of other issues for grasps 😉

@Adam-it Adam-it closed this as completed Sep 8, 2024
Adam-it added a commit that referenced this issue Sep 8, 2024
@Adam-it
Updates Sign in method. Closes: #291, #266, #265, #225 (#296)
083d2e9 
## 🎯 Aim

The aim is to update the default sign in method to add functionality to
sign in over local entra app registration and also add additional
features that will allow to create such an app reg as easily as possible

## 📷 Result

![sign-in-entra-app-reg-form](https://github.com/user-attachments/assets/490f10b8-2eec-49ad-844d-bd56a84a203d)

## ✅ What was done

- [X] Refactored project structure
- [X] Updated readme images
- [X] Updated walkthrough steps to add more guidance
- [X] Added form that will create entra app reg for SPFx using CLI for
M365
- [X] Refactored sign in experiance
- [X] Minor bug fix in sample gallery filters

## 🔗 Related issue

Closes: #291, #266, #265, #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmaestrini tmaestrini

Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v3.X
Development

Successfully merging a pull request may close this issue.

Updates Sign in method. Closes: #291, #266, #265, #225 Adam-it/vscode-viva
2 participants
@Adam-it @tmaestrini