Clarify that package_json_file is relative to GITHUB_WORKSPACE #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the description for package_json_file parameter to specify that the path must be relative to the repository root.
KSXGitHub
reviewed
Dec 5, 2025
Collaborator
KSXGitHub
left a comment
KSXGitHub
left a comment
There was a problem hiding this comment.
Alternatively, you can replace path.join with path.resolve.
zkochan
reviewed
Dec 7, 2025
zkochan
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the description for
package_json_fileparameter to specify that the path must be relative to the repository root.If, for example, you give an absolute file path, it doesn't work, because the provided path will always be prefixed by
GITHUB_WORKSPACEataction-setup/src/install-pnpm/run.ts
Line 64 in 41ff726