Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateConfig.ignoreDependencies only ignoring last item in array #5639

Closed
michaelhays opened this issue Nov 16, 2022 · 0 comments · Fixed by #5643
Closed

updateConfig.ignoreDependencies only ignoring last item in array #5639

michaelhays opened this issue Nov 16, 2022 · 0 comments · Fixed by #5643
Assignees
Milestone

Comments

@michaelhays
Copy link

pnpm version:

7.16.0

Code to reproduce the issue:

pnpm update --latest

Expected behavior:

pnpm doesn't update any dependencies in pnpm.updateConfig.ignoreDependencies

Actual behavior:

pnpm only doesn't update the last dependency in pnpm.updateConfig.ignoreDependencies

Additional information:

With this package.json:

{
  "pnpm": {
    "updateConfig": {
      "ignoreDependencies": [
        "nanoid",
        "next"
      ]
    }
  },
  "dependencies": {
    "nanoid": "3",
    "next": "12"
  }
}

Running pnpm update --latest actually updates the version of nanoid:

  "dependencies": {
    "nanoid": "^4.0.0",
    "next": "12"
  }

However, when reverting back to nanoid@3 and switching the order of ignoreDependencies:

      "ignoreDependencies": [
        "next",
        "nanoid"
      ]

Running pnpm update --latest now updates the version of next:

  "dependencies": {
    "nanoid": "3",
    "next": "^13.0.3"
  }
  • node -v prints: v16.18.0
  • Windows, macOS, or Linux?: Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants