The global store should always be on the same disk on which installation is done

[zkochan]

pnpm version:

0.64.8

Code to reproduce the issue:

Run pnpm install no a secondary disk (lets say it is disk D), not the one on which your system lives.

Expected behavior:

Installation is successful and a store on disk D is created/used

Actual behavior:

A store on disk C is used and pnpm fails because hardlinks cannot be cross-disk.

Additional information:

• node -v prints: any
• Windows, OS X, or Linux?: Windows

Temporary fix

If you want to do installations on a different disk till this is not fixed, just change the location of your global store to a directory on the disk you wanna use.

npm config set store-path <path to the store>

in my case MacOS (X), i'll try it out on Ubuntu later (might work, not sure)

ERROR EXDEV: cross-device link not permitted,
link '/Users/dym/.pnpm-store/1/registry.npmjs.org/gm/1.23.0/.npmignore'
-> '/Volumes/Data/work/site/node_modules/.registry.npmjs.org/gm/1.23.0/node_modules/gm+stage/.npmignore'

[zkochan]

Seems like this package can help us implement this https://www.npmjs.com/package/drivelist

[pstoev]

@zkochan how do you think that check would work? Checking against only physical drives? I think the issue is reproducible on logical drives as well...

[zkochan]

Yes. You are right. This seems easy to fix on Windows. I am not so sure how to distinguish different partitions/disks on Linux and MacOS

…

On Mon, Apr 24, 2017, 13:37 Plamen Stoev ***@***.***> wrote: @zkochan <https://github.com/zkochan> how do you think that check would work? Checking against only physical drives? I think the issue is reproducible on logical drives as well... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#712 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1pm3VYFBBQcCucslKzVAbuL0Q2c73Zks5rzHuAgaJpZM4NEsZs> .

[zkochan]

@noformnocontent could you please check on your environment whether path.parse correctly detects the root on your different disks?

tried on Ubuntu,

ERROR EXDEV: cross-device link not permitted,
link '/home/dym/.pnpm-store/1/registry.npmjs.org/morgan/1.8.1/HISTORY.md' ->
'/media/dym/Data/work/site/node_modules/.registry.npmjs.org/morgan/1.8.1/node_modules/morgan+stage/HISTORY.md'  

path.parse:

> path.parse('/media/dym/Data/work/site/package.json')
{ root: '/',
  dir: '/media/dym/Data/work/site',
  base: 'package.json',
  ext: '.json',
  name: 'package' }

[zkochan]

thanks, I hoped it would return /media/dym as root. In this case we'll have to use the drivelist package. I haven't found anything else

pattern is /media/<user>/<mounted_volume>, so in that case /media/dym/Data
i'll try the path.parse on mac later today

what happens if you run pnpm in a Docker/Kubernetes enviroment -- should be no problem, right?

[zkochan]

I guess if it has one filesystem then it should be fine

[zkochan]

OK, so on Windows it will be <disk letter>:\

on Linux /media/<user>/<mounted_volume>

on OSX /Volumes/<mounted_volume>

Seems easy.

[minecrawler]

on Linux /media//<mounted_volume>

what if I do

$ sudo mount /somedir && cd /somedir && pnpm install

on Linux, with /somedir defined in /etc/fstab? What about

$ sudo mount /dev/sdc1 /mnt/tmp && cd /mnt/tmp && pnpm install

?

On Linux, any directory might be on a different disk! Not everyone uses Ubuntu and its way of handling some things...

[pstoev]

thanks, I hoped it would return /media/dym as root. In this case we'll have to use the drivelist package. I haven't found anything else

@zkochan wouldn't it be enough if we "extract" (e.g. dir.substring second slash, regex, etc) info from the dir property. I'm talking the path.parse approach?

[minecrawler]

Here is a way to get the filesystems on Linux: https://www.cyberciti.biz/faq/linux-command-list-mounted-devices-in-terminal/

tl;dr: read the file /proc/mounts. On each line, the first bit is the partition (for example /dev/sda3) and the second bit is the mount-point (for example /). You will have to check the given paths against the mount-points and find the closest match (be careful to not only always find the root-fs)