-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pnpm autofixing lockfile is not working #7213
Comments
I'm having the same issue, quite giving up on pnpm, every single pnpm install cause a similar error for me is this
always rename is not permitted error. I've added full control on the folder, changed security permission, but nothing helped. i'm trying to avoid running the pnpm as root |
Can you copy paste pnpm-lock? |
Deleting of whole node_modules is not working, too |
This happened to me in my windows machine, just after importing a |
Is v8.8.0 the first version where it gets broken? Here's a related change shipped with 8.8.0: #7117. Maybe this introduced the issue. |
This might fix the issue: zkochan/packages#181. But I couldn't reproduce it. |
any way i can try it? |
@ImUrX build pnpm from the repository and see if the issue is fixed. |
I'm no longer able to replicate my issue in the windows machine I had the issues with in |
I encountered this again today
this is the ndjson reporter that could be related
|
No idea if this is a permanent fix, but after manually patching the For the record, on Windows 10 EDIT: Well, It may happens it was just a lucky run. I tried adding a package and I keep getting again the |
I assume this started happening when we switched to sync filesystem operations. In the past pnpm used async fs operations but now we use sync operations in multiple worker threads that run in parallel. The async version of the rename function is doing the retry after a small delay, which might result in better success rate. The sync version retries immediately. We can try to add "busy waiting" to the sync version. |
If this change happened this year, this could be it. Earlier this year I was not having issues at all (don't remember the version though). Then it started popping up very often, never on the same file. With the proposed change above to retry, it continues to do the error, but way less frequently! To me it seems related to the number of packages installed at once. Chances are that the process reading the When adding very few packages, it seems less frequent, but when doing a fresh |
Verify latest release
pnpm version
8.9.2
Which area(s) of pnpm are affected? (leave empty if unsure)
No response
Link to the code that reproduces this issue or a replay of the bug
No response
Reproduction steps
Describe the Bug
Produced errors.
or with another:
npmrc:
Expected Behavior
Install is not failing.
All works correctly for 8.7.6 version
Which Node.js version are you using?
18.18.0
Which operating systems have you used?
If your OS is a Linux based, which one it is? (Include the version if relevant)
No response
The text was updated successfully, but these errors were encountered: