Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the fewer-dependencies resolution strategy by default #2042

Merged
merged 1 commit into from Sep 30, 2019

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Sep 30, 2019

This change is making pnpm a little bit slower but the resulting node_modules will have fewer duplicates of packages. Our Twitter poll results show that deduplication is more important for our users the speed: https://twitter.com/pnpmjs/status/1109800824744656898

BREAKING CHANGE:

by default resolution-strategy=fewer-dependencies

BREAKING CHANGE:

by default resolution-strategy=fewer-dependencies
@zkochan zkochan added this to the v4.0 milestone Sep 30, 2019
Copy link
Member

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@zkochan zkochan merged commit 0cfca86 into master Sep 30, 2019
@zkochan zkochan deleted the fewer-dependencies branch September 30, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants