Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(pkgs-graph): optimize createNode by using Map #6284

Closed
wants to merge 2 commits into from
Closed

perf(pkgs-graph): optimize createNode by using Map #6284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c182f0c
perf(pkgs-graph): optimize createNode by using Map
marvinhagemeister Mar 26, 2023
1df7c8e
perf(pkg-links): use Map instead of object
marvinhagemeister Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions pkg-manager/headless/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,27 @@ async function getRootPackagesToLink (
}
): Promise<LinkedDirectDep[]> {
const projectSnapshot = lockfile.importers[opts.importerId]
const allDeps = {
...projectSnapshot.devDependencies,
...projectSnapshot.dependencies,
...projectSnapshot.optionalDependencies,
const allDeps = new Map<string, string>();

const devDependencies = projectSnapshot.devDependencies
if (devDependencies) {
for (const name in devDependencies) {
allDeps.set(name, devDependencies[name])
}
}
const requiredDependencies = projectSnapshot.dependencies
if (requiredDependencies) {
for (const name in requiredDependencies) {
allDeps.set(name, requiredDependencies[name])
}
}
const optionalDependencies = projectSnapshot.optionalDependencies
if (optionalDependencies) {
for (const name in optionalDependencies) {
allDeps.set(name, optionalDependencies[name])
}
}

return (await Promise.all(
Object.entries(allDeps)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give this a proper review back on my desktop once I'm there, but this code is suspect as it's getting the own properties of the Map instance now, versus iteration over its contents.

.map(async ([alias, ref]) => {
Expand Down
18 changes: 14 additions & 4 deletions workspace/pkgs-graph/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,20 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
return { graph, unmatched }

function createNode (pkg: Package): string[] {
const dependencies = {
...(!opts?.ignoreDevDeps && pkg.manifest.devDependencies),
...pkg.manifest.optionalDependencies,
...pkg.manifest.dependencies,
const dependencies = new Map<string, string>();
if (!opts?.ignoreDevDeps) {
const devDependencies = pkg.manifest.devDependencies
for (const name in devDependencies) {
dependencies.set(name, devDependencies[name])
}
}
const optionalDependencies = pkg.manifest.optionalDependencies;
for (const name in optionalDependencies) {
dependencies.set(name, optionalDependencies[name])
}
const requiredDependencies = pkg.manifest.dependencies
for (const name in requiredDependencies) {
dependencies.set(name, requiredDependencies[name])
}

return Object.entries(dependencies)
Expand Down