fix(cafs): avoid race on extracting files from tarballs #8703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On running addFilesFromTarball with many workers in the pool there were sometimes race conditions on moving files having same content. It resulted in ERR_PNPM_ENOENT and ERR_PNPM_TARBALL_EXTRACT exceptions during install. The issue was introduced in v8.7.0 and generated many defect reports. Closes pnpm#7676, potentially pnpm#7607, pnpm#7697 and others
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Oct 28, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Oct 28, 2024
##### [v9.12.3](https://github.com/pnpm/pnpm/blob/HEAD/pnpm/CHANGELOG.md#9123) ##### Patch Changes - Don't purge `node_modules`, when typing "n" in the prompt that asks whether to remove `node_modules` before installation [#8655](pnpm/pnpm#8655). - Fix a bug causing pnpm to infinitely spawn itself when `manage-package-manager-versions=true` is set and the `.tools` directory is corrupt. - Use `crypto.hash`, when available, for improved performance [#8629](pnpm/pnpm#8629). - Fixed a race condition in temporary file creation in the store by including worker thread ID in filename. Previously, multiple worker threads could attempt to use the same temporary file. Temporary files now include both process ID and thread ID for uniqueness [#8703](pnpm/pnpm#8703). - All commands should read settings from the `package.json` at the root of the workspace [#8667](pnpm/pnpm#8667). - When `manage-package-manager-versions` is set to `true`, errors spawning a self-managed version of `pnpm` will now be shown (instead of being silent). - Pass the find command to npm, it is an alias for npm search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On running addFilesFromTarball with many workers in the pool there were sometimes race conditions on moving files having same content. It resulted in ERR_PNPM_ENOENT and ERR_PNPM_TARBALL_EXTRACT exceptions during install. The issue was introduced in v8.7.0 and generated many defect reports.
Closes #7676, potentially #7607, #7697 and others