Add new pages "Apps"/"Stakes" for POSDAO network #1476

@igorbarinov is there some work already done for the POSDAO network, or should I add the new styles and sections on a new development branch with some static / mock content, for somebody to add some logic to it later?

(I'm not sure if it's you who I should be asking these questions, if there's somebody else available please let me know).

acravenho · 2019-02-26T20:57:23Z

@gabitoesmiapodo Yes, please add this to a separate branch and we can have someone take a look at it for the logic.

gabitoesmiapodo · 2019-02-27T17:17:22Z

@acravenho

I finally got the Blockscout running locally.

Is there a preferred approach, or a guide to implement a theme for a new network (POSDAO in this case)?

I see the new designs implement not only color and icon changes, but also some layout modifications, new sections, etc., so there might be some changes affecting other networks too.

acravenho · 2019-02-27T17:23:26Z

@gabitoesmiapodo There is no infrastructure setup currently to make structural changes that will not affect the entire application. However, we can enable features through configuration settings and environment variables for chain specific features. We do this currently with the xdai chain.

I would add the changes to the current infrastructure and then we can enable them with an environment variable POSDAO = true.

gabitoesmiapodo · 2019-02-27T17:43:47Z

@acravenho

Just to clarify: so there's no way to change a theme dinamically? Each themed version is a different instance built and deployed for each network?

If that's the case, I asume I should just make all the necessary modifications to existing layout(s), add new icons and SCSS, and then the remaining issues will be solved when building and deploying the new / updated instances.

Sorry for all the questions, BTW.

acravenho · 2019-02-27T17:50:15Z

@gabitoesmiapodo

Just to clarify: so there's no way to change a theme dinamically? Each themed version is a different instance built and deployed for each network?

That's correct, each chain is built separately so there is a bit of customization that can be done here.

Let's make the changes to SCSS by adding a new POSDAO theme and including all assets that will be needed by the new dynamic theme.

gabitoesmiapodo · 2019-02-27T19:56:44Z

@acravenho

I'm not able tu update the theme's colors.

This is all I could get for now.

I can change the logo (in this case I'm using the POA logo, but I have the POSDAO logo available too), and I can connect to ganache, display transactions, etc.

But if I do this on theme/variables:

// @import "neutral_variables";
@import "dai_variables";
@import "theme/base_variables";

... nothing happens. I see some changes on the console logs, but nothing reflects on the browser, even if I update manually.

Is there something I'm missing?

acravenho · 2019-02-27T21:08:09Z

@gabitoesmiapodo I believe you're missing the _ before dai_variables.

varasev · 2019-02-28T06:51:59Z

@pashagonchar I left my comments in https://invis.io/YPQNPDTW4ZB - some pages need to be supplemented with a few UI elements and we also need to have a few extra layouts (see my comments for all of those pages).

gabitoesmiapodo · 2019-02-28T11:35:59Z

@acravenho

It seems that wasn't the problem (the underscore is not needed for this type of @import).

I finally got it working by stopping the server, deleting all the files in the blockscout/apps/block_scout_web/priv/static/css/ folder, and by doing mix phx.server again.

I don't know why that fixed the problem, but It updates everything correctly on every file save now.

@varasev

If there are new designs needed, I think @pashagonchar will address that, and update the Zeplin files.

* master: add --unsafe-perm parameter install phantomjs fix test that depended on date fix test fix dialyzer update cache key update elixir version in circle ci upgrade elixir to 1.8.1 feat: add an admin method to import contract methods.

* master: (80 commits) add CHANGELOG entry modify query to fetch failed contract creations add CHANGELOG entry add entry to CHANGELOG Update 1.3.7 changelog add more logging to code fixer process do not fetch burn address balance fix gettext fix typo fix usd fee allow to set first indexing block Add PIRL to Readme Changelog update select queries by batches feat: rpc address to list addresses fix credo Reduce block_rewards in the catchup fetcher Add regression test for #1584 Added guard for check block number before fetch it add second query ... # Conflicts: # apps/block_scout_web/lib/block_scout_web/templates/layout/_topnav.html.eex

* master: do not allow update code mix format return full responses mix format create separate migration allow creation different smart contract for address_hash add response bodies handle invalid address_hash add upsert for decompied smart contacts add changelog entry send response Revert "Fix flaky tests" add moduledoc add auth add endpoint to create decompiled smart contracts create decompiled smart contracts

* master: fix gettext fix second typo add changelog entry fix typo Set internal_transactions_indexed_at for empty blocks Add regression test for #1642 Update test CHANGELOG update fix color for release link add infinite timeout for Repo.transaction set infinity timeout for addresses without code

* master: Optimize token holder count updates when importing address current balances

* master: Update changelog Address review comments Add a migration to mark all invalid blocks as non-consensus (#1644) Force consensus loss for parent block if its hash mismatches parent_hash Add regression test for #1644 feat: add listcontracts endpoint fix view test use correct type for evm_version define evm versions in one place fix dialyzer set only hours in env var fetch transaction period from env variables add changelog entry add petersburg evm version add CHANGELOG entry fix credo fix tests use cache for estimated transaction count add transaction count cache

* master: fix CHANGELOG entry add changelog entry do not fail if multuple matching tokens are found add CHANGELOG entry try to compil with the latest evm version if bytecode doesn't match add changelog entry update gettext add line break between decompiler version and decompiled code show multiple decompiled contracts fix current selected tab for decompiled code fix mobile dropdown menu add decompiled contract tab add a simple view that show single decomplid code entry add decompiled contract tab endpoint add query to return decompiled contracts make tab visible if contract has any decompiled code

* master: (28 commits) feat: verify contracts via an RPC endpoint Remove obsolete InvalidConsensus.Worker Discard child block with parent_hash not matching hash of imported block Expand non-consensus block regression test to test for race conditions Remove obsolete ConsensusEnsurer feat: add not_decompiled_with_version filter Update fetcher_test.exs mix format fix test update gettext fix build remove fetching token 2 times update CHANGELOG update tokens in fetcher add CHANGELOG entry exclude decompiled smart contract from encoding add CHANGELOG entry update metadata in controller add CHANGELOG entry decrease token metadata update interval ...

* master: use literal nul use null value add CHANGELOG entry fix failing in rpc if balance is empty

* master: add changelog entry use seconds as period measure

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: fix CHANGELOG: feature -> chore fix gettext add CHANGELOG entry add check mark to decompiled contract tab Update CHANGELOG Update telegram link # Conflicts: # apps/block_scout_web/lib/block_scout_web/templates/address/_tabs.html.eex # apps/block_scout_web/priv/gettext/default.pot # apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po

* master: feat: Add RSK support

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: feat: Add RSK support # Conflicts: # CHANGELOG.md

* master: feat: slightly more informative json rpc error messages + logging

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: feat: slightly more informative json rpc error messages + logging

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: (fix) logo dimensions (update) posdao logo

* master: (25 commits) Describe indexer structure and list existing fetchers (#1763) add more test cases fix CR issues add CHANGELOG entry do not hardcode values in tests fix credo add CHANGELOG entry add today's token balance from previous value add CHANGELOG entry fix gettext add label change package version download chrom directly fix command order fix script try using chrome headless for wallaby fix failing test update phantom js on circle ci bumbp cache version fix gettext ... # Conflicts: # apps/block_scout_web/priv/gettext/default.pot # apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: (25 commits) Describe indexer structure and list existing fetchers (#1763) add more test cases fix CR issues add CHANGELOG entry do not hardcode values in tests fix credo add CHANGELOG entry add today's token balance from previous value add CHANGELOG entry fix gettext add label change package version download chrom directly fix command order fix script try using chrome headless for wallaby fix failing test update phantom js on circle ci bumbp cache version fix gettext ... # Conflicts: # apps/block_scout_web/priv/gettext/default.pot # apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po

…-pages-for-POSDAO-network- * feature/new-theming-capabilites: (update) internationalization files (fix) tooltip color (update) address button icon (fix) transaction color (fix) blocks margin update changelog update gettext handle case when total supply is nil Update CHANGELOG --f -> -f update changelog Update CHANGELOG block counter calculate only consensus block Add --f flag to clear_build.sh script delete static folder

* master: Fix mix format test add cache for block counter

* master: ex_abi version bump to 0.2.0

…POSDAO-network- (Feature) New pages for POSDAO network

saneery · 2019-06-11T10:24:00Z

@gabitoesmiapodo could you check your updates that relates to this PR#1853? After merging master into production-posdao there seems color schema is broken

vbaranov · 2019-06-11T10:28:37Z

@saneery

you should remove import "neutral_variables" from

https://github.com/poanetwork/blockscout/blob/production-posdao/apps/block_scout_web/assets/css/theme/_variables.scss#L2

saneery · 2019-06-11T10:32:56Z

@vbaranov
Thanks!
Should I add this change to my PR#2106?

maxgrapps · 2019-06-11T10:34:56Z

@vbaranov
Thanks!
Should I add this change to my PR#2106?

To use variables for xdai, you should connect dai_variables instead of posdao_variables

vbaranov · 2019-06-11T10:36:28Z

Should I add this change to my PR#2106?

yes, please

maxgrapps · 2019-06-11T10:46:27Z

@vbaranov
Thanks!
Should I add this change to my PR#2106?

@saneery And we should use dai_logo.svg logo there

vbaranov · 2019-06-11T10:49:10Z

@maxgrapps if we don't need to use posdao_variables and posdao logo, please add a PR to remove those obsolete assets from master

gabitoesmiapodo self-assigned this Feb 26, 2019

gabitoesmiapodo added enhancement New feature or request in progress design labels Feb 28, 2019

igorbarinov pinned this issue Mar 19, 2019

gabitoesmiapodo added a commit that referenced this issue Mar 27, 2019

Merge branch 'master' into feature/#1476-add-styles-for-POSDAO-network

50eed58

* master: Optimize token holder count updates when importing address current balances

igorbarinov assigned saneery Apr 2, 2019

gabitoesmiapodo added a commit that referenced this issue Apr 4, 2019

Merge branch 'master' into feature/#1476-add-styles-for-POSDAO-network

6d0abb8

* master: use literal nul use null value add CHANGELOG entry fix failing in rpc if balance is empty

gabitoesmiapodo mentioned this issue Apr 4, 2019

(Feature) Add new styles and "Stakes" page for POSDAO network #1704

Closed

gabitoesmiapodo added a commit that referenced this issue Apr 5, 2019

Merge branch 'master' into feature/#1476-add-styles-for-POSDAO-network

6e3f632

* master: add changelog entry use seconds as period measure

gabitoesmiapodo added a commit that referenced this issue Apr 15, 2019

Merge branch 'master' into feature/#1476-add-styles-for-POSDAO-network

86fd212

* master: feat: Add RSK support

gabitoesmiapodo added a commit that referenced this issue Apr 15, 2019

Merge branch 'feature/#1476-add-styles-for-POSDAO-network' into feature/

2f59674

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: feat: Add RSK support # Conflicts: # CHANGELOG.md

gabitoesmiapodo mentioned this issue Apr 15, 2019

(Feature) Add styles for POSDAO Network #1758

Closed

gabitoesmiapodo added a commit that referenced this issue Apr 15, 2019

Merge branch 'master' into feature/#1476-add-styles-for-POSDAO-network

8167ddb

* master: feat: slightly more informative json rpc error messages + logging

gabitoesmiapodo added a commit that referenced this issue Apr 16, 2019

Merge branch 'feature/#1476-add-styles-for-POSDAO-network' into feature/

6c62191

#1638-new-style-for-lukso-network * feature/#1476-add-styles-for-POSDAO-network: (fix) logo dimensions (update) posdao logo

gabitoesmiapodo mentioned this issue Apr 22, 2019

(Feature) New theming capabilites #1807

Merged

4 tasks

gabitoesmiapodo mentioned this issue Apr 26, 2019

(Feature) New pages for POSDAO network #1853

Merged

gabitoesmiapodo added a commit that referenced this issue Apr 29, 2019

Merge branch 'master' into feature/#1476-new-pages-for-POSDAO-network-

e6c6ab0

* master: Fix mix format test add cache for block counter

gabitoesmiapodo added a commit that referenced this issue Apr 29, 2019

Merge branch 'master' into feature/#1476-new-pages-for-POSDAO-network-

be651df

* master: ex_abi version bump to 0.2.0

vbaranov added a commit that referenced this issue Apr 29, 2019

Merge pull request #1853 from poanetwork/feature/#1476-new-pages-for-…

900dfbe

…POSDAO-network- (Feature) New pages for POSDAO network

vbaranov added this to the 2.0.0 milestone May 1, 2019

saneery mentioned this issue May 15, 2019

Set blockscout to work with staking app in POSDAO network #1709

Closed

saneery mentioned this issue Jun 3, 2019

Question modal window #2089

Closed

vbaranov added the Staking dApp label Jun 21, 2019

vbaranov removed this from the 2.0.0 milestone Jul 23, 2019

vbaranov assigned liberumed Sep 3, 2019

vbaranov closed this as completed Oct 15, 2020

vbaranov unpinned this issue Oct 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new pages "Apps"/"Stakes" for POSDAO network #1476

Add new pages "Apps"/"Stakes" for POSDAO network #1476

pashagonchar commented Feb 22, 2019 •

edited

gabitoesmiapodo commented Feb 26, 2019 •

edited

igorbarinov commented Feb 26, 2019

gabitoesmiapodo commented Feb 26, 2019

gabitoesmiapodo commented Feb 26, 2019

acravenho commented Feb 26, 2019

gabitoesmiapodo commented Feb 27, 2019

acravenho commented Feb 27, 2019

gabitoesmiapodo commented Feb 27, 2019 •

edited

acravenho commented Feb 27, 2019

gabitoesmiapodo commented Feb 27, 2019 •

edited

acravenho commented Feb 27, 2019

varasev commented Feb 28, 2019 •

edited

gabitoesmiapodo commented Feb 28, 2019

saneery commented Jun 11, 2019 •

edited

vbaranov commented Jun 11, 2019

saneery commented Jun 11, 2019

maxgrapps commented Jun 11, 2019

vbaranov commented Jun 11, 2019

maxgrapps commented Jun 11, 2019

vbaranov commented Jun 11, 2019

Navigation Menu

Add new pages "Apps"/"Stakes" for POSDAO network #1476

Add new pages "Apps"/"Stakes" for POSDAO network #1476

Comments

pashagonchar commented Feb 22, 2019 • edited

gabitoesmiapodo commented Feb 26, 2019 • edited

igorbarinov commented Feb 26, 2019

gabitoesmiapodo commented Feb 26, 2019

gabitoesmiapodo commented Feb 26, 2019

acravenho commented Feb 26, 2019

gabitoesmiapodo commented Feb 27, 2019

acravenho commented Feb 27, 2019

gabitoesmiapodo commented Feb 27, 2019 • edited

acravenho commented Feb 27, 2019

gabitoesmiapodo commented Feb 27, 2019 • edited

acravenho commented Feb 27, 2019

varasev commented Feb 28, 2019 • edited

gabitoesmiapodo commented Feb 28, 2019

saneery commented Jun 11, 2019 • edited

vbaranov commented Jun 11, 2019

saneery commented Jun 11, 2019

maxgrapps commented Jun 11, 2019

vbaranov commented Jun 11, 2019

maxgrapps commented Jun 11, 2019

vbaranov commented Jun 11, 2019

pashagonchar commented Feb 22, 2019 •

edited

gabitoesmiapodo commented Feb 26, 2019 •

edited

gabitoesmiapodo commented Feb 27, 2019 •

edited

gabitoesmiapodo commented Feb 27, 2019 •

edited

varasev commented Feb 28, 2019 •

edited

saneery commented Jun 11, 2019 •

edited