Fix BlocksTransactionsMismatch temporary fetcher #2027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
This solves a problem that was found with
BlocksTransactionsMismatch
temporary fetcher:block with no transactions were not taken into account, so they were not checked and never had their
refetch_needed
field set to false.Additionally, a
consensus
filtering has been added to theAddRefetchNeededToBlock
migration to save some unnecessary update in it and some checks from the temporary fetcher.Checklist for your PR
CHANGELOG.md
with this PR