Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache for first page of uncles #2733

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@pasqu4le
Copy link
Contributor

pasqu4le commented Sep 24, 2019

closes #2430

Checklist for your PR

@pasqu4le pasqu4le self-assigned this Sep 24, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 24, 2019

Pull Request Test Coverage Report for Build 153a032f-c6e1-4402-889d-2b6eed743c95

  • 18 of 26 (69.23%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 78.478%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/temporary/uncles_without_index.ex 0 1 0.0%
apps/explorer/lib/explorer/chain.ex 10 17 58.82%
Totals Coverage Status
Change from base Build 14d780e7-db72-4ccb-97fb-89d6679c74b5: -0.04%
Covered Lines: 5291
Relevant Lines: 6742

💛 - Coveralls
@pasqu4le pasqu4le force-pushed the pp_uncles_cache branch from 123bce4 to 6c38eeb Sep 24, 2019
@pasqu4le pasqu4le requested review from vbaranov and ayrat555 Sep 24, 2019
@vbaranov

This comment has been minimized.

Copy link
Collaborator

vbaranov commented Oct 2, 2019

@pasqu4le please resolve merging conflicts

@pasqu4le pasqu4le force-pushed the pp_uncles_cache branch from 6c38eeb to c83c0d3 Oct 3, 2019
@pasqu4le

This comment has been minimized.

Copy link
Contributor Author

pasqu4le commented Oct 3, 2019

@vbaranov Done

@vbaranov vbaranov merged commit e19b0a6 into master Oct 3, 2019
14 of 15 checks passed
14 of 15 checks passed
coverage/coveralls Coverage decreased (-0.04%) to 78.478%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check_formatted Your tests passed on CircleCI!
Details
ci/circleci: coveralls_merge Your tests passed on CircleCI!
Details
ci/circleci: credo Your tests passed on CircleCI!
Details
ci/circleci: dialyzer Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: gettext Your tests passed on CircleCI!
Details
ci/circleci: jest Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: sobelow Your tests passed on CircleCI!
Details
ci/circleci: test_geth_http_websocket Your tests passed on CircleCI!
Details
ci/circleci: test_geth_mox Your tests passed on CircleCI!
Details
ci/circleci: test_parity_http_websocket Your tests passed on CircleCI!
Details
ci/circleci: test_parity_mox Your tests passed on CircleCI!
Details
@vbaranov vbaranov deleted the pp_uncles_cache branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.