Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove networks images preload #2846

Merged
merged 2 commits into from Nov 12, 2019

Conversation

@vbaranov
Copy link
Collaborator

vbaranov commented Nov 7, 2019

Motivation

After returning of old networks menu #2797, networks images preload wasn't removed #2570

Changelog

Remove preload of network images for enhanced networks menu since that menu was disabled for a while and networks menu styles itself

Checklist for your Pull Request (PR)

@vbaranov vbaranov force-pushed the vb-remove-images-preload branch 2 times, most recently from 8903019 to 58a615b Nov 7, 2019
@vbaranov vbaranov requested a review from ayrat555 Nov 7, 2019
@vbaranov vbaranov self-assigned this Nov 7, 2019
@vbaranov vbaranov marked this pull request as ready for review Nov 7, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 7, 2019

Pull Request Test Coverage Report for Build eb194103-058e-4689-a97f-6e84f6686571

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.8%) to 75.641%

Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/transform/addresses.ex 1 75.0%
apps/block_scout_web/lib/block_scout_web/views/layout_view.ex 2 86.36%
apps/indexer/lib/indexer/block/fetcher.ex 3 83.13%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/http.ex 7 64.0%
apps/ethereum_jsonrpc/lib/ethereum_jsonrpc/web_socket/web_socket_client.ex 47 18.75%
Totals Coverage Status
Change from base Build edb464cc-8f27-47bb-976a-e7c21c530861: -0.8%
Covered Lines: 5248
Relevant Lines: 6938

💛 - Coveralls
@vbaranov vbaranov force-pushed the vb-remove-images-preload branch from 58a615b to 36a327b Nov 7, 2019
@vbaranov vbaranov merged commit 7286cbf into master Nov 12, 2019
10 of 11 checks passed
10 of 11 checks passed
ci/circleci: test_parity_http_websocket CircleCI is running your tests
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check_formatted Your tests passed on CircleCI!
Details
ci/circleci: credo Your tests passed on CircleCI!
Details
ci/circleci: dialyzer Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: gettext Your tests passed on CircleCI!
Details
ci/circleci: jest Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: sobelow Your tests passed on CircleCI!
Details
ci/circleci: test_parity_mox Your tests passed on CircleCI!
Details
@vbaranov vbaranov deleted the vb-remove-images-preload branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.