Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent filling pending_block_operations table for RSK variant #2949

Merged
merged 1 commit into from Jan 15, 2020

Conversation

@vbaranov
Copy link
Collaborator

vbaranov commented Jan 14, 2020

Motivation

RSK chain doesn't have internal transactions. Thus, Blockscout needs to skip filling pending_block_operations table for RSK variant since there blocks with pending internal txs are stored there.

Changelog

Skip logic inside new_pending_operations for EthereumJSONRPC.RSK variannt.

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jan 14, 2020
@vbaranov vbaranov force-pushed the vb-prevent-fill-pbo-for-rsk-variant branch from 20a67c3 to 0f658e0 Jan 14, 2020
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Pull Request Test Coverage Report for Build 8bc488d4-0654-4771-bfd3-913c68b14be3

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.248%

Totals Coverage Status
Change from base Build 1b033276-5d8e-4eb2-b64b-edbfe7748df8: 0.0%
Covered Lines: 5378
Relevant Lines: 7147

💛 - Coveralls
@vbaranov vbaranov force-pushed the vb-prevent-fill-pbo-for-rsk-variant branch from 0f658e0 to e1b8ff5 Jan 14, 2020
@vbaranov vbaranov merged commit 130a408 into master Jan 15, 2020
12 checks passed
12 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check_formatted Your tests passed on CircleCI!
Details
ci/circleci: coveralls_merge Your tests passed on CircleCI!
Details
ci/circleci: credo Your tests passed on CircleCI!
Details
ci/circleci: dialyzer Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: gettext Your tests passed on CircleCI!
Details
ci/circleci: jest Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: sobelow Your tests passed on CircleCI!
Details
ci/circleci: test_parity_mox Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 75.248%
Details
@vbaranov vbaranov deleted the vb-prevent-fill-pbo-for-rsk-variant branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.