Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `creationMethod` to `EthereumJSONRPC.Parity.Trace.Action.entry_to_elixir` #2950

Open
wants to merge 1 commit into
base: master
from

Conversation

@varasev
Copy link

varasev commented Jan 14, 2020

While testing of Staking DApp with the latest Parity nightly build (based on Parity tree https://github.com/paritytech/parity-ethereum/tree/d8a0d382292a0afb9986dcfbea9e022f617bb5f1 created 14th January 2020) the new error appeared I’ve never seen before:

2020-01-14T15:01:30.802 fetcher=internal_transaction count=10 [error] Task #PID<0.1769.0> started from Indexer.Fetcher.InternalTransaction terminating
** (FunctionClauseError) no function clause matching in EthereumJSONRPC.Parity.Trace.Action.entry_to_elixir/1
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity/trace/action.ex:47: EthereumJSONRPC.Parity.Trace.Action.entry_to_elixir({"creationMethod", "create"})
    (elixir) lib/map.ex:216: Map.new_transform/3
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity/trace.ex:457: EthereumJSONRPC.Parity.Trace.entry_to_elixir/1
    (elixir) lib/map.ex:216: Map.new_transform/3
    (elixir) lib/enum.ex:1336: Enum."-map/2-lists^map/1-0-"/2
    (elixir) lib/enum.ex:1336: Enum."-map/2-lists^map/1-0-"/2
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/parity.ex:84: EthereumJSONRPC.Parity.trace_replay_block_transactions_responses_to_internal_transactions_params/2
    (indexer) lib/indexer/fetcher/internal_transaction.ex:165: Indexer.Fetcher.InternalTransaction.run/2
Function: &Indexer.BufferedTask.log_run/1
    Args: [%{batch: [243, 4, 1, 3, 5, 6, 0, 2, 37, 43], callback_module: Indexer.Fetcher.InternalTransaction, callback_module_state: [transport: EthereumJSONRPC.HTTP, transport_options: [http: EthereumJSONRPC.HTTP.HTTPoison, url: "http://localhost:8541", method_to_url: [eth_getBalance: "http://localhost:8541", trace_block: "http://localhost:8541", trace_replayTransaction: "http://localhost:8541"], http_options: [recv_timeout: 600000, timeout: 600000, hackney: [pool: :ethereum_jsonrpc]]], variant: EthereumJSONRPC.Parity], metadata: [fetcher: :internal_transaction]}]
It doesn’t appear for the Parity built on 3rd January 2020. I suspect it is related to some latest changes they made during last two weeks, especially https://github.com/paritytech/parity-ethereum/commit/87e108058125098ec404951393a054f08aebef7a

It doesn’t appear for the Parity built on 3rd January 2020. Seems it is related to some latest changes they made during last two weeks, especially paritytech/parity-ethereum@87e1080#diff-debfa2252d1aa7c1d937b41dcfb8e829R281

It can be fixed by adding creationMethod to EthereumJSONRPC.Parity.Trace.Action.entry_to_elixir function. I tried to do that locally and the error disappeared.

It may be better to merge this after Parity team releases beta with these changes.

Extends EthereumJSONRPC.Parity.Trace.Action.entry_to_elixir
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Pull Request Test Coverage Report for Build f9d48da3-1251-4ac0-953e-e183a3e2ff78

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.231%

Totals Coverage Status
Change from base Build 1b033276-5d8e-4eb2-b64b-edbfe7748df8: 0.0%
Covered Lines: 5376
Relevant Lines: 7146

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.