Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guard that addresses is enum in values function in read contract page #2961

Merged
merged 1 commit into from Jan 20, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jan 20, 2020

#2907

Motivation

Read page is broken if addresses output is not a list

Changelog

Check that addresses type is an enum

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Jan 20, 2020
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jan 20, 2020
@vbaranov vbaranov changed the title Handle addresses is enum in values function in read contract page Add a guard that addresses is enum in values function in read contract page Jan 20, 2020
@coveralls
Copy link

coveralls commented Jan 20, 2020

Pull Request Test Coverage Report for Build db62c813-c7f7-493b-8f91-64bcdd5a830e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 75.248%

Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain_spec/genesis_data.ex 5 9.09%
Totals Coverage Status
Change from base Build 10acea3e-75cc-4479-9c48-3d6a58431711: -0.07%
Covered Lines: 5378
Relevant Lines: 7147

💛 - Coveralls

@vbaranov vbaranov merged commit e8c4224 into master Jan 20, 2020
@vbaranov vbaranov deleted the vb-handle-memory-output branch January 20, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants