Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken export to CSV #3009

Merged
merged 1 commit into from Feb 14, 2020
Merged

Conversation

@vbaranov
Copy link
Collaborator

vbaranov commented Feb 14, 2020

Motivation

Export to CSV button returns redirect to not found page. It was broken in #2834

Changelog

add checksummed hash in address_id param for transactions_csv method

Checklist for your Pull Request (PR)

@vbaranov vbaranov self-assigned this Feb 14, 2020
@vbaranov vbaranov force-pushed the vb-fix-redirect-to-checksummed-address branch from 7f354d5 to 39e1817 Feb 14, 2020
@vbaranov vbaranov force-pushed the vb-fix-redirect-to-checksummed-address branch from 39e1817 to fdf8b6a Feb 14, 2020
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 14, 2020

Pull Request Test Coverage Report for Build 749cf47a-4cad-4d04-bbb7-db41ed4e101b

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.402%

Totals Coverage Status
Change from base Build 1d67edc3-b799-4fc7-a46f-526569bc43d0: 0.0%
Covered Lines: 5438
Relevant Lines: 7212

💛 - Coveralls
@vbaranov vbaranov merged commit f704982 into master Feb 14, 2020
12 checks passed
12 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check_formatted Your tests passed on CircleCI!
Details
ci/circleci: coveralls_merge Your tests passed on CircleCI!
Details
ci/circleci: credo Your tests passed on CircleCI!
Details
ci/circleci: dialyzer Your tests passed on CircleCI!
Details
ci/circleci: eslint Your tests passed on CircleCI!
Details
ci/circleci: gettext Your tests passed on CircleCI!
Details
ci/circleci: jest Your tests passed on CircleCI!
Details
ci/circleci: release Your tests passed on CircleCI!
Details
ci/circleci: sobelow Your tests passed on CircleCI!
Details
ci/circleci: test_parity_mox Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 75.402%
Details
@vbaranov vbaranov deleted the vb-fix-redirect-to-checksummed-address branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.