From b8d60cbbd1a9b9d5aaacf819510ab1788c75e4fd Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Fri, 9 Oct 2015 20:39:58 +0200 Subject: [PATCH 01/12] set the Activity title via AndroidManifest.xml --- .../java/com/github/pockethub/ui/gist/CreateGistActivity.java | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java index 5e240b47b..13863a142 100644 --- a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java +++ b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java @@ -63,7 +63,6 @@ protected void onCreate(Bundle savedInstanceState) { publicCheckBox = finder.find(R.id.cb_public); ActionBar actionBar = getSupportActionBar(); - actionBar.setTitle(R.string.new_gist); actionBar.setIcon(R.drawable.ic_github_gist_white_32dp); actionBar.setDisplayHomeAsUpEnabled(true); From 73112ad2ddcf85daf606d34ae06c6770ec88a9bd Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Fri, 9 Oct 2015 21:02:47 +0200 Subject: [PATCH 02/12] let android handle the up navigation --- app/src/main/AndroidManifest.xml | 10 ++++++++-- .../github/pockethub/ui/gist/CreateGistActivity.java | 6 ------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index c067beebe..9c366efb6 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -1,6 +1,7 @@ + xmlns:tools="http://schemas.android.com/tools" + package="com.github.pockethub"> @@ -47,7 +48,12 @@ + android:label="@string/create_gist" + android:parentActivityName="com.github.pockethub.ui.MainActivity" + tools:ignore="UnusedAttribute"> + diff --git a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java index 13863a142..38e1b22ad 100644 --- a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java +++ b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java @@ -108,12 +108,6 @@ public boolean onOptionsItemSelected(MenuItem item) { case R.id.m_apply: createGist(); return true; - case android.R.id.home: - finish(); - Intent intent = new Intent(this, MainActivity.class); - intent.addFlags(FLAG_ACTIVITY_CLEAR_TOP | FLAG_ACTIVITY_SINGLE_TOP); - startActivity(intent); - return true; default: return super.onOptionsItemSelected(item); } From 858ab018c862778873909b9dca9b6a1f860b433c Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Fri, 9 Oct 2015 21:22:03 +0200 Subject: [PATCH 03/12] update the Layout (CoordinatorLayout + FloatingActionButton) --- .../main/res/layout/activity_gist_create.xml | 35 ++++++++++++++----- app/src/main/res/values/dimens.xml | 3 +- 2 files changed, 29 insertions(+), 9 deletions(-) diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index d15a40364..ac7e9a9f2 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -13,22 +13,32 @@ ~ See the License for the specific language governing permissions and ~ limitations under the License. --> - - + android:theme="@style/ToolbarTheme" > - + + + + android:layout_height="match_parent" + app:layout_behavior="@string/appbar_scrolling_view_behavior"> - + + + - + \ No newline at end of file diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 53802d4a1..22290799d 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -19,4 +19,5 @@ 0dp 152dp 48dp - + 16dp + \ No newline at end of file From ec8558eb06b682cdcef1d3d7885657c65424303e Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Fri, 9 Oct 2015 21:30:21 +0200 Subject: [PATCH 04/12] use the new Floating Action Button and drop the old menu button --- .../pockethub/ui/gist/CreateGistActivity.java | 42 ++++++------------- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java index 38e1b22ad..e7ef3b4b4 100644 --- a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java +++ b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java @@ -15,25 +15,20 @@ */ package com.github.pockethub.ui.gist; -import android.content.Intent; import android.os.Bundle; +import android.support.design.widget.FloatingActionButton; import android.support.v7.app.ActionBar; import android.text.TextUtils; -import android.view.Menu; -import android.view.MenuItem; +import android.view.View; import android.widget.CheckBox; import android.widget.EditText; import com.alorma.github.sdk.bean.dto.response.Gist; import com.github.pockethub.R; import com.github.pockethub.ui.BaseActivity; -import com.github.pockethub.ui.MainActivity; import com.github.pockethub.ui.TextWatcherAdapter; import com.github.pockethub.util.ShareUtils; -import static android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP; -import static android.content.Intent.FLAG_ACTIVITY_SINGLE_TOP; - /** * Activity to share a text selection as a public or private Gist */ @@ -47,7 +42,7 @@ public class CreateGistActivity extends BaseActivity { private CheckBox publicCheckBox; - private MenuItem createItem; + private FloatingActionButton floatingActionButton; @Override protected void onCreate(Bundle savedInstanceState) { @@ -61,6 +56,7 @@ protected void onCreate(Bundle savedInstanceState) { nameText = finder.find(R.id.et_gist_name); contentText = finder.find(R.id.et_gist_content); publicCheckBox = finder.find(R.id.cb_public); + floatingActionButton = finder.find(R.id.fab); ActionBar actionBar = getSupportActionBar(); actionBar.setIcon(R.drawable.ic_github_gist_white_32dp); @@ -82,6 +78,13 @@ public void onTextChanged(CharSequence s, int start, int before, int count) { } }); updateCreateMenu(); + + floatingActionButton.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + createGist(); + } + }); } private void updateCreateMenu() { @@ -90,27 +93,8 @@ private void updateCreateMenu() { } private void updateCreateMenu(CharSequence text) { - if (createItem != null) - createItem.setEnabled(!TextUtils.isEmpty(text)); - } - - @Override - public boolean onCreateOptionsMenu(Menu options) { - getMenuInflater().inflate(R.menu.activity_gist_create, options); - createItem = options.findItem(R.id.m_apply); - updateCreateMenu(); - return true; - } - - @Override - public boolean onOptionsItemSelected(MenuItem item) { - switch (item.getItemId()) { - case R.id.m_apply: - createGist(); - return true; - default: - return super.onOptionsItemSelected(item); - } + if (floatingActionButton != null) + floatingActionButton.setEnabled(!TextUtils.isEmpty(text)); } private void createGist() { From c40bbb70995452942515f0401254be83c0d7d873 Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Fri, 9 Oct 2015 22:46:57 +0200 Subject: [PATCH 05/12] update the Layout (material design + TextInputLayout) --- .../main/res/layout/activity_gist_create.xml | 67 +++++++------------ app/src/main/res/values/dimens.xml | 1 + app/src/main/res/values/styles.xml | 8 ++- app/src/main/res/values/theme.xml | 1 - 4 files changed, 33 insertions(+), 44 deletions(-) diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index ac7e9a9f2..23ee14834 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -44,70 +44,54 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingBottom="10dp"> + android:paddingLeft="@dimen/activity_content_padding" + android:paddingRight="@dimen/activity_content_padding" + android:paddingTop="8dp"> - - - - + android:minHeight="@dimen/touch_target" + android:text="@string/make_public"/> - + + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:hint="@string/description"/> + - + + android:hint="@string/file_name" + android:singleLine="true"/> + + - + - + - + @@ -117,7 +101,6 @@ android:layout_height="wrap_content" android:layout_gravity="end|bottom" android:layout_margin="@dimen/fab_margin" - android:src="@drawable/ic_done_white_24dp" - /> + android:src="@drawable/ic_done_white_24dp" /> - \ No newline at end of file + diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 22290799d..f9520cbac 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -19,5 +19,6 @@ 0dp 152dp 48dp + 16dp 16dp \ No newline at end of file diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index a71f971cc..d111a0e56 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -238,4 +238,10 @@ @color/color_navigation_view_icon - + + + \ No newline at end of file diff --git a/app/src/main/res/values/theme.xml b/app/src/main/res/values/theme.xml index 07b1c8f92..55de0a30d 100644 --- a/app/src/main/res/values/theme.xml +++ b/app/src/main/res/values/theme.xml @@ -27,7 +27,6 @@ @style/Widget.Styled.ActionBar @style/Widget.Styled.ActionBar false - @color/background From 2b35090309b77519dc32edc59eca447869e3e77f Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Sat, 10 Oct 2015 17:44:52 +0200 Subject: [PATCH 06/12] Use an actionbar menu item instead of FAB --- .../pockethub/ui/gist/CreateGistActivity.java | 36 +++++++++++++------ .../main/res/layout/activity_gist_create.xml | 11 +----- .../main/res/menu/activity_create_gist.xml | 10 ++++++ 3 files changed, 36 insertions(+), 21 deletions(-) create mode 100644 app/src/main/res/menu/activity_create_gist.xml diff --git a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java index e7ef3b4b4..aede20440 100644 --- a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java +++ b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java @@ -16,9 +16,11 @@ package com.github.pockethub.ui.gist; import android.os.Bundle; -import android.support.design.widget.FloatingActionButton; import android.support.v7.app.ActionBar; +import android.support.v7.widget.Toolbar; import android.text.TextUtils; +import android.view.Menu; +import android.view.MenuItem; import android.view.View; import android.widget.CheckBox; import android.widget.EditText; @@ -42,7 +44,7 @@ public class CreateGistActivity extends BaseActivity { private CheckBox publicCheckBox; - private FloatingActionButton floatingActionButton; + private MenuItem menuItem; @Override protected void onCreate(Bundle savedInstanceState) { @@ -50,13 +52,12 @@ protected void onCreate(Bundle savedInstanceState) { setContentView(R.layout.activity_gist_create); - setSupportActionBar((android.support.v7.widget.Toolbar) findViewById(R.id.toolbar)); + setSupportActionBar((Toolbar) findViewById(R.id.toolbar)); descriptionText = finder.find(R.id.et_gist_description); nameText = finder.find(R.id.et_gist_name); contentText = finder.find(R.id.et_gist_content); publicCheckBox = finder.find(R.id.cb_public); - floatingActionButton = finder.find(R.id.fab); ActionBar actionBar = getSupportActionBar(); actionBar.setIcon(R.drawable.ic_github_gist_white_32dp); @@ -78,13 +79,26 @@ public void onTextChanged(CharSequence s, int start, int before, int count) { } }); updateCreateMenu(); + } - floatingActionButton.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { + @Override + public boolean onCreateOptionsMenu(Menu menu) { + super.onCreateOptionsMenu(menu); + getMenuInflater().inflate(R.menu.activity_create_gist, menu); + menuItem = menu.findItem(R.id.create_gist); + updateCreateMenu(); + return true; + } + + @Override + public boolean onOptionsItemSelected(MenuItem item) { + switch (item.getItemId()){ + case R.id.create_gist: createGist(); - } - }); + return true; + default: + return super.onOptionsItemSelected(item); + } } private void updateCreateMenu() { @@ -93,8 +107,8 @@ private void updateCreateMenu() { } private void updateCreateMenu(CharSequence text) { - if (floatingActionButton != null) - floatingActionButton.setEnabled(!TextUtils.isEmpty(text)); + if (menuItem != null) + menuItem.setEnabled(!TextUtils.isEmpty(text)); } private void createGist() { diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index 23ee14834..ca4d5bfd2 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -17,8 +17,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" android:layout_width="match_parent" - android:layout_height="match_parent" - android:orientation="vertical"> + android:layout_height="match_parent"> - - diff --git a/app/src/main/res/menu/activity_create_gist.xml b/app/src/main/res/menu/activity_create_gist.xml new file mode 100644 index 000000000..b68f6fccb --- /dev/null +++ b/app/src/main/res/menu/activity_create_gist.xml @@ -0,0 +1,10 @@ + + + + \ No newline at end of file From 9df371bdc7da4abab6d1b8238e2f09e6c8d799ff Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Sun, 11 Oct 2015 15:06:09 +0200 Subject: [PATCH 07/12] use an collapsing toolbar --- .../main/res/layout/activity_gist_create.xml | 126 ++++++++++-------- 1 file changed, 74 insertions(+), 52 deletions(-) diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index ca4d5bfd2..40afef805 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -16,6 +16,7 @@ @@ -26,72 +27,93 @@ android:minHeight="?attr/actionBarSize" android:theme="@style/ToolbarTheme" > - - - - + app:layout_scrollFlags="scroll|exitUntilCollapsed" + app:titleEnabled="false"> - - - + android:layout_marginLeft="?attr/actionBarSize" + android:layout_marginStart="?attr/actionBarSize" + android:layout_marginTop="?attr/actionBarSize" + android:orientation="vertical" + android:padding="@dimen/activity_content_padding" + app:layout_collapseMode="parallax"> - - - - + android:minHeight="@dimen/touch_target" + android:nextFocusDown="@+id/et_gist_description" + android:nextFocusForward="@+id/et_gist_description" + android:text="@string/make_public"/> - + - - + + + - + + + - + + + + + + + + + + - - - - From 7dce0c78e5fb9881c5a57467e524bf8c2987d314 Mon Sep 17 00:00:00 2001 From: Lars Grefer Date: Sun, 11 Oct 2015 17:23:57 +0200 Subject: [PATCH 08/12] drop the gist icon and update the existing ones --- .../pockethub/ui/gist/CreateGistActivity.java | 2 -- .../drawable-hdpi/ic_github_gist_black_24dp.png | Bin 414 -> 369 bytes .../drawable-hdpi/ic_github_gist_white_32dp.png | Bin 308 -> 0 bytes .../drawable-ldpi/ic_github_gist_black_24dp.png | Bin 277 -> 250 bytes .../drawable-ldpi/ic_github_gist_white_32dp.png | Bin 305 -> 0 bytes .../drawable-mdpi/ic_github_gist_black_24dp.png | Bin 259 -> 296 bytes .../drawable-mdpi/ic_github_gist_white_32dp.png | Bin 258 -> 0 bytes .../ic_github_gist_black_24dp.png | Bin 312 -> 467 bytes .../ic_github_gist_white_32dp.png | Bin 370 -> 0 bytes .../ic_github_gist_black_24dp.png | Bin 537 -> 587 bytes .../ic_github_gist_white_32dp.png | Bin 485 -> 0 bytes .../ic_github_gist_black_24dp.png | Bin 489 -> 795 bytes .../ic_github_gist_white_32dp.png | Bin 656 -> 0 bytes .../main/res/layout/activity_gist_create.xml | 4 ++-- 14 files changed, 2 insertions(+), 4 deletions(-) delete mode 100644 app/src/main/res/drawable-hdpi/ic_github_gist_white_32dp.png delete mode 100644 app/src/main/res/drawable-ldpi/ic_github_gist_white_32dp.png delete mode 100644 app/src/main/res/drawable-mdpi/ic_github_gist_white_32dp.png delete mode 100644 app/src/main/res/drawable-xhdpi/ic_github_gist_white_32dp.png delete mode 100644 app/src/main/res/drawable-xxhdpi/ic_github_gist_white_32dp.png delete mode 100644 app/src/main/res/drawable-xxxhdpi/ic_github_gist_white_32dp.png diff --git a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java index aede20440..005630547 100644 --- a/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java +++ b/app/src/main/java/com/github/pockethub/ui/gist/CreateGistActivity.java @@ -21,7 +21,6 @@ import android.text.TextUtils; import android.view.Menu; import android.view.MenuItem; -import android.view.View; import android.widget.CheckBox; import android.widget.EditText; @@ -60,7 +59,6 @@ protected void onCreate(Bundle savedInstanceState) { publicCheckBox = finder.find(R.id.cb_public); ActionBar actionBar = getSupportActionBar(); - actionBar.setIcon(R.drawable.ic_github_gist_white_32dp); actionBar.setDisplayHomeAsUpEnabled(true); String text = ShareUtils.getBody(getIntent()); diff --git a/app/src/main/res/drawable-hdpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-hdpi/ic_github_gist_black_24dp.png index 47296572e27a5abed3441ca35995789e7a0e97b1..cab97f39671d95935d0956b1ed0dd08a03b730c5 100644 GIT binary patch delta 305 zcmV-10nYxO1MvcoNq-YbL_t(|+U%H%4TB&MKouQ;5$pzTU>%_wbu;Y-Zcs;HfSUG5 zj)WrB9v`hKms~hJ0?z|ZFw2r0Omg!NQqaWZ!BW)5m^oQ751TvNmgSX?M+MSg6vT*{S?aY56!U-?@LMEQ8?;;WIYF^dFrlDWNSF{%$J_QUZ|f3O zQiLc_J}{&y`v%GvhP;L>P?d4I)azszr$wzn_2!uvZQUoR{g*B~L4&gShEKk9{7685 z3AD7!nuvF^hAMKm-}NeOo3ac32#75L$4YW+c?mE8(dd_DIaR~A00000NkvXXu0mjf DYM6sE delta 350 zcmV-k0ipi!0-ghqNq;~|L_t(|+U%Ht4T3NbMG-qdM{op2kP(MEQ?duEX4n|r~^;{`hOV^B4q=SEq1BeyaK`D z9@QFh;!vckkX}8TA= zJQU1OP~!}HeDx9)KetGVu%u-)6N)sR5)Sl^;YR2iC|j7`Q`P~sWzSn17^5}RfKm%M zW6c>m)b)n>bXP#rLScIDPR diff --git a/app/src/main/res/drawable-hdpi/ic_github_gist_white_32dp.png b/app/src/main/res/drawable-hdpi/ic_github_gist_white_32dp.png deleted file mode 100644 index c34c7610858e0be83fe38bf16cbbfba5704777ba..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 308 zcmeAS@N?(olHy`uVBq!ia0vp^1|ZDA1|-9oezpTC$r9IylHmNblJdl&R0hYC{G?O` z&)mfH)S%SFl*+=BsWw1G*F0SuLn>~)nHk8}qQK*lxS9Q{+G_QOE3WeU{$bc2Fd-$h4+w&^PZ zO$EAyr6A|FH?RLzwW7|K{L5`UY$ov>ZO%WaAv)plOC|x%vdo>+eGdumVzO!B7kaPF z(Av1^m~O6;3>Hrz=~Y-4Bc6&GdW!YKxYGqOwPJWDxHuUHer z1hiy^bVKREg>U!i?4G!i!|Ji@&1VW6LF;217#S=o?@fFoJ2x5R6i-(_mvv4FO#o2z BbS(e? diff --git a/app/src/main/res/drawable-ldpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-ldpi/ic_github_gist_black_24dp.png index d53ef83019ae6bd7b334f62f103c103e42ec145b..0e2d8e17f40e61b392558060679c3de2f223cc65 100644 GIT binary patch delta 185 zcmV;q07n0n0{Q`vNq?M4L_t(|+G1j$5@3Nbn3-7ufRq7=`Y-(b`)31)!H8tge~<(a ze<0Ej0g%N&gBVdnK?VV_1F=p4sfAh&229inBib7Tbany|p9f+AC`XBuL`)2{VLHmJ}1BnJ5 z02<^7VlbgeGy)|UiNPSX$Qqfb6-Kl-2pDDtpl}0X0VoEs4REPv!DR@L0tLPRQUri# zkYSF%FuFj{MQDa30yS*_VGtWChSgZ0t^6NmtJzExn?y0 O0000;J|p%o=L! z8Vv>)nB3NE`mea4F=l%67bjUxcAqVM&4Njc1`)p-Z!mP`GYBcW>2nLVoo5f?RNzUG zc4~Dz8Od-$oI!1d%ck0f6bp_V2B~ihEsi-WBA7yWFP`L?=i?~#U->{y&a}m+`8|w| z&c0aild0dLji2LLipt@8%o~|R_8%83xuKJwxaffw%d4LZDS9n#1}78(62zopr04u3% AfB*mh diff --git a/app/src/main/res/drawable-mdpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-mdpi/ic_github_gist_black_24dp.png index 7930868369935e157a1ed29e39698afc7676a25c..b9e13bd51c82a74b16c7f8a644f26516530d40ca 100644 GIT binary patch delta 231 zcmVoL_t(|+G1cB>VOf(U}k1f08;0HSb#z^KLD}e-@ktzfH*8j z5(-emA3!lVKmiG(ngR5I0}%fQ;s$b^4$=!X!vQA7MC&*h0TuwmQvit1191Y9SOQc` zfFcW^2J8o710c>vlFEmQ?I&aj6Oo2r0AfcZX-B9SK}(p3HDDZ=aX!H0p=_co8JI{W z-`p;j_dLO>6;>S}LHr^Z`JC0RUXXROES4d+h)K002ovPDHLkV1n4jSyBK1 delta 194 zcmV;z06qVx0)qmONq?nDL_t(|+G1cB>VOfM!_3UGpBje#{rkremj(ZU)B`9c2Pl9r z&;mxRvLFk9xPe@kgY-fj2?tEHj)M_m0We(qf!F|vZvYY_Cz3EC8OWax6@L%J3Q+tW zDmI^@NQN4a0Of7~Ccg(D3}QpY63{In+6PE3|BuZOZ1Mw=Ogr($0WM$Q5y$WW%_Etp wqJr3DO11@~Wf5I#G^$rPG_Nv;J^%~)34hDgpul7D((&!dPrkX0O&*(1KRwN=&J`3m#Tnc*MA>Kjx;z zGnXYwpHyQ0d>0SwuPv2W*-*N_tNOqE8f$Km#f6*(3@>GzCr>|=&;xWYgQu&X%Q~lo FCII35XWak* diff --git a/app/src/main/res/drawable-xhdpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-xhdpi/ic_github_gist_black_24dp.png index 81621ac2b80544b8a2ee43a851b3b4ee4a58644e..140bb298df91bce93c56d0a41aa7592bab2c26a4 100644 GIT binary patch delta 405 zcmV;G0c!rZ0@DMKNPhu!Nkl_6iFV#hfYV^pfg*6i9qmgO&a*kZF2XLQ)! zPN(np-T)YWj)y~HH+z8)$7Uy7G0ziREo`Q|$AzVz!ihrrC4XGB8TtS?Zt7wPm$K{f zz`gH63ZMWApaA~_0Qc+y+Xpt=;<4l@k^-PWzIIyrBL_i!bx)B5KrMU~+Mn+j>#kN7 zSSbh)4quhO8^*q&F(U~90mA#Tw`}^UZy^lMJ9FUq-Ju^ z42*@43_o}Y4S$7@4nOJ{xD_Hq_|Xq>3&fhSucgC_>_QBLKVLD{6^)677u!Z_5PJ&d z7>{dsN{QdjjgTnNbBD)udGsHd0w{n2C_q&8c@J3n1VB}U-PIC0CYY7YlyRNs z^Uo&$e3`!wYflpg_vObcmLYqiQmHQVE5HEGdBDZOTn=J%00000NkvXXu0mjfxOKK9 delta 248 zcmV2;jSJuO&RiHj%3l{r2a#91kZ$c4se`iv^^3ng9fXU2$#o%O>KnO#%Ldw;b;y z0GWZ3`cwnR37ftrt4j)~wboTwMD<5A~E#>4-Yg)GE<9fD&q-R&An8t_1=FRq|npV&t;ucLK6V!M2;T- diff --git a/app/src/main/res/drawable-xxhdpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-xxhdpi/ic_github_gist_black_24dp.png index 7eaf4beda3205271eb9f808ad46765212f51be25..c14cfd5c2801b5e55adc59842c8e0b09b549aab7 100644 GIT binary patch delta 525 zcmV+o0`mQt1j_`FNq_B0L_t(|+U(rHZG$ir24M1%LysMyBQQdkpexV`s%}7!J$8b2 zg-k$4$O@gH86d=cmVAf^0fUX7ZT-JwaR?^yC)>o1NKqgNf*?q$+1Q@A-R>GbymEO= zyv-*rpIvuuya6%J7a!`(I>$F7y-c><0!PC%8IGQkh<=s29Dm17B8v+>XFSDBwryu| zk)b)~CsB~SMcZZr-Gs+(m7)$$7iw-DDi8nx2tWV=5P$##AOt`F0#NoqykIQN9@E@< zwXPfE3b@s);OpXu^JlJ8&%{xtZt3v;s#n@*fOE{xgtdibO&b=X#mFwX$cU8 zm~;4`KgiJToqzs?VQf$MXwKkth`$DI`h>M*<0p)eu0TyM4$WOR07H(8Jm55L+85G|nn>&{{|mIIB(4zLBJG zR=tb)LXyN;{WkB4B#jf~dyoavST8Ciacsvwwp>F14SyijGwS8PY2QPt7u0k9*(V7g z;prm2O?xa>0R$ifKmY;|fB*y_009WO$)YC?y{v*W0vg&0+-K7MlaC>G$hd<{wr%pc zdHq~D5j_>-d&en8|FOWkGmt?#Fw({#J!CMfJ{ac>w;%*T5G3#X3ormL$X77g#|jDn P0000CsI)mJSrIn^P zyPTdOxxSNI_mNccOfpJ1FOgbs#F305P8BI>Xir*jM3Ia#PMN$Yt{?SA*OtGi^^Rl$ zz@W>I3XaJ&~dbpObj@hNK96xfF!B+BhP^dD)N9;c62~r8Lv;AKU zHD%kb1xW;_&k*}>AGwMGRgf-yAKJT`zuaWT0pzx~mQ$!114v~qX0IRL5;aU#0Rjjh zfB*uB00a;~00o+%?~AP>d=q*#q=;8C0Rjl17=X4D1v)cM6G8}?ZtemM00N*Go)ohA QC;$Ke07*qoM6N<$g8in*+yDRo diff --git a/app/src/main/res/drawable-xxhdpi/ic_github_gist_white_32dp.png b/app/src/main/res/drawable-xxhdpi/ic_github_gist_white_32dp.png deleted file mode 100644 index 442d9f42754230a6cbad3a075bea0e7a10622ed8..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 485 zcmeAS@N?(olHy`uVBq!ia0vp^2_VeD1|%QND7OGok|nMYCBgY=CFO}lsSJ)O`AMk? zp1FzXsX?iUDV2pMQ*9U+7~4Hv978H@y}5h0ugO5fHF3s|1?MKeoNYAg#aWk-FI(ET z-S_G-zjY|?n|RY@7NDUFD^BhC%6*!3qb=u`L(|Ux@6Zuv;!t2<={c>K{Uv|yikl0> z7H}&uum~_PaWF8lG%zqZFfb}KFbFs>xQTAiIsNk2EpN+eu4js@hxQkr(o@%NpVIZe z^;=;@;8Pye1l28PAG%I8p3)$`aIb7!h@~@Uh4Gf@K%rpc_AikabUTurt{zuQcb}-6 z@L1n$6ZfxOswVeYr}C_7Ygxt`!nGnp_AJ+mtF9p#sc$(~NY=fynk_s*uncs?EHLG|3Z;eRsE(pArt0~J}Av8~Vb5@wmrL~>yne8#`$A9mvF%EE>8vG^3 z-f(}>rg`Efm03x}K>tF$4GJAtXf*ue+^zER|IsawU||4(hSGm55)8^7K@l(ah--jE NJYD@<);T3K0RZF$zfb@G diff --git a/app/src/main/res/drawable-xxxhdpi/ic_github_gist_black_24dp.png b/app/src/main/res/drawable-xxxhdpi/ic_github_gist_black_24dp.png index a3561ef5207d8e592b554dd15c4c2091770fefca..2826b9487e452a3233d13bf76b852e53ff4b9804 100644 GIT binary patch delta 735 zcmV<50wDeA1DghrNPhyoNklewppZ%o)Cz?cQuRyWRV1=!Z{wz^~2j0e|oZMXZg4?O+1jng0a* zP6?+WEg@(O5Rq%MTfzCu*c0@vZ9kf!TEH`B|M6B}TENet1hnuy9wWe;YZd8lUYTt> zGtPE0@;k{i^gy=8dNU{brZg$q4=* z-@5MDEF{R(;O8bmrU*YL2{Kjqxk!*H!_Ps2OdY;<34byN_?jiiT;OY!AajDRQ35w) zrhFx=b>P#~GG$K9U1PU6N*AO>g2pjvv@syH1g#T-Q3v5v612ikG7B18f@b*1rlDg= z&<;Q8b->UPa)6)wLTo4rxxiO(B^)SWVJs*!m|B2MANczc zOdTs>>GMz*0{(}$iB!i5+-Utjxgmo91P}xufFJ+?1OW&j2tWWq00IaC5I_(x{lvN< zQ^#6SBBRtXim-^!00~*dC$tNC0dHJJp#tvV8(5bSOBu#L`-7G;3~B+c@S3jZOZe;1 z$7q7r6K>m&zanCr*_&$#3&0n*#pi=xoS3Un! R&yoND002ovPDHLkV1oP~LnZ(K delta 427 zcmbQu_L6ymM?GV=r;B4q#jQ7Yqw@|Kh`3&ylCr?SNJ2x9ztb!9stD7z{G9c=iu-o7 zZT@I1$ivJ41Pe6cv*Qi=F1zNOKJ&RUbeZ+UqfQKrEDa5HGZ&@(zva1A>IyTDBTEAV zlLG^zLIZ<<0|SQw1B(Cy6NkfkrelRx_vE8jZeE(8S8r=n-||29w?wSER{Mmu`qpn{ z6)Rtrs3s_Gx%zPFs>@Rw)EDlRiCbkA%UNN#WjRnN*r@$O=mq7DT8GQOwZh#ss}G#Y z&pD;|;_MjocbdP99h*IMx4=YQEj(6EV~Ls9vYl0-17JZ)9l5QK6^_`Z>+SF z&+}j2u*|=I+wJ=us&6>;PVLrRn#lOS<@vESlX$)u~#OBpQ8=vX;9dpg~b;CP2Q9K#ryE9KmvvV1R|bk9bi~GUNhCz|+;w JWt~$(69Dq9uOk2e diff --git a/app/src/main/res/drawable-xxxhdpi/ic_github_gist_white_32dp.png b/app/src/main/res/drawable-xxxhdpi/ic_github_gist_white_32dp.png deleted file mode 100644 index 99d45afbca1f1a1645653e9c06da341effb99cd9..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 656 zcmeAS@N?(olHy`uVBq!ia0vp^4Is?H1|$#LC7uRSk|nMYCBgY=CFO}lsSJ)O`AMk? zp1FzXsX?iUDV2pMQ*9U+n2bDK978H@y}1)u)MOyQmT+tGtCL@riKJH){0dmT;im7W zzw8~>Z`3C+M2ZO_fTU%-JA1@-i=Iy2J4`^UP(dhzjBdd<7x{QpVG?*Nm=d&~Zu|di z>+z4f|1_`FzqIM6zkT)V+&{05Z!c-wKdZQE@}lGH5B@xxb8X3skBlAJ=N_uL_VYW` ze74UE`tpNeOZLCpzFl(i4d2fGF9#}JUski=D3&=uQmeBS9Zldq{9W4{pmIr_SdO@rL*`-9h?Jzf1=);T3K F0RTYR*n9v0 diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index 40afef805..d677d2b51 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -36,8 +36,8 @@ Date: Sun, 27 Dec 2015 22:22:12 +0100 Subject: [PATCH 09/12] remove the left margin --- app/src/main/res/layout/activity_gist_create.xml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index d677d2b51..115d645ab 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -36,8 +36,6 @@ Date: Tue, 29 Dec 2015 16:32:04 +0100 Subject: [PATCH 10/12] apply some suggestions - move the checkbox below the inputs - use white as accent color - add the snap scroll-flag --- .../main/res/layout/activity_gist_create.xml | 46 +++++++++---------- app/src/main/res/values/theme.xml | 1 + 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/app/src/main/res/layout/activity_gist_create.xml b/app/src/main/res/layout/activity_gist_create.xml index 115d645ab..ec36920ed 100644 --- a/app/src/main/res/layout/activity_gist_create.xml +++ b/app/src/main/res/layout/activity_gist_create.xml @@ -23,36 +23,25 @@ + app:layout_scrollFlags="scroll|exitUntilCollapsed|snap" + app:titleEnabled="false" + app:toolbarId="@+id/toolbar"> - - + android:nextFocusForward="@+id/et_gist_name" /> + android:singleLine="true" /> + + @android:color/white @color/ripple_material_dark + #FFFFFF