Share button in repositories view #335

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

anupcowkur commented Mar 28, 2013

Added a small share button in the options menu when viewing repositories.

This will allow users to share the HTML URL of the currently viewed repository with other Android apps (Facebook, Twitter, Google+ etc)

This feature was requested in github/android#319

Contributor

anupcowkur commented Apr 6, 2013

@mrdomopanda Good idea. Code updated.

Contributor

anupcowkur commented Apr 6, 2013

The travis build keeps failing even though the integration tests run perfectly fine on my machine. I think it is because of a known issue with travis configuration:
https://github.com/travis-ci/travis-worker/issues/56

Here is screenshot of integration tests completing successfully on my mac:
testsuccess

And this is the screenshot of the failed travis build:
travisscreenshot

Contributor

sbennett18 commented Apr 6, 2013

My pull requests seem to be having the same issues with Travis.

Also, you should probably also remove the string you added in the first commit and maybe add a subject for the sharing that'll show up in the subject line of whatever app you share with.
Something like:

ShareUtils.create("Repository " + repository.getName(), repository.getHtmlUrl());

would be simple.

Contributor

anupcowkur commented Apr 6, 2013

@mrdomopanda I let the string be. I think it adds a personal touch to the Intent Chooser the users see. I updated the code to add a subject.

Contributor

sbennett18 commented Apr 6, 2013

My mistake. I didn't see that you were still using the string. I like it!

Contributor

kevinsawicki commented Apr 26, 2013

Hi, thanks for adding this, I've merged it to master.

I did back out wrapping the intent in a createChooser call since that wasn't used elsewhere in other share actions inside the app and I wanted to keep things consistent.

I am definitely up for revisiting using createChooser for all share activities started in the app but would want to do it across the board instead of just in one activity.

Contributor

anupcowkur commented Apr 26, 2013

@kevinsawicki Cool. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment