New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to not use CPU autodetection #667

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bmwiedemann

bmwiedemann commented Oct 8, 2018

Ensure to not use CPU autodetection
when building distro packages.

Without this patch, config.h's OCL_KERNEL_TARGET_CPU got this value and
lib/CL/devices/basic/basic.c
lib/CL/pocl_llvm_utils.cc
lib/CL/pocl_llvm_build.cc
used the value, creating variations in build results.

Note: I tested that it builds reproducibly on different CPUs, but not that it works.

Ensure to not use CPU autodetection
when building distro packages.

Without this patch, config.h OCL_KERNEL_TARGET_CPU got this value and
lib/CL/devices/basic/basic.c
lib/CL/pocl_llvm_utils.cc
lib/CL/pocl_llvm_build.cc
used the value, creating variations in build results.

franz added a commit to franz/pocl that referenced this pull request Oct 11, 2018

@franz

This comment has been minimized.

Contributor

franz commented Oct 15, 2018

Hello, are you trying to get reproducible builds ? Your patch kind-of works, but i've tried to fix it properly in git master. Please test and let me know if it works.

@bmwiedemann

This comment has been minimized.

bmwiedemann commented Oct 15, 2018

Hi, yes, I'm working on reproducible builds for openSUSE, but even without that, we want to have distribution packages that do not depend on the build CPU type.

Found the relevant commit e99f4ca

@bmwiedemann

This comment has been minimized.

bmwiedemann commented Oct 15, 2018

Tested successfully. So this PR can be closed.

@franz franz closed this Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment