Ensure to not use CPU autodetection #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when building distro packages. Without this patch, config.h OCL_KERNEL_TARGET_CPU got this value and lib/CL/devices/basic/basic.c lib/CL/pocl_llvm_utils.cc lib/CL/pocl_llvm_build.cc used the value, creating variations in build results.
franz
added a commit
to franz/pocl
that referenced
this pull request
Oct 11, 2018
|
Hello, are you trying to get reproducible builds ? Your patch kind-of works, but i've tried to fix it properly in git master. Please test and let me know if it works. |
|
Hi, yes, I'm working on reproducible builds for openSUSE, but even without that, we want to have distribution packages that do not depend on the build CPU type. Found the relevant commit e99f4ca |
|
Tested successfully. So this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Ensure to not use CPU autodetection
when building distro packages.
Without this patch, config.h's
OCL_KERNEL_TARGET_CPUgot this value andlib/CL/devices/basic/basic.c
lib/CL/pocl_llvm_utils.cc
lib/CL/pocl_llvm_build.cc
used the value, creating variations in build results.
Note: I tested that it builds reproducibly on different CPUs, but not that it works.